Fix errorprone #3151
Merged
Fix errorprone #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comment
Siedlerchr
added
the
status: ready-for-review
koppor
requested changes
Aug 23, 2017
| @@ -20,7 +20,7 @@ public void testFixAuthorNatbib() { | |||
| // Is not cached! | |||
| Assert.assertTrue(AuthorList | |||
| .fixAuthorNatbib("John von Neumann and John Smith and Black Brown, Peter").equals(AuthorList | |||
| .fixAuthorNatbib("John von Neumann" + (0 == 1 ? "" : " and ") | |||
| .fixAuthorNatbib("John von Neumann" + (false ? "" : " and ") | |||
There was a problem hiding this comment.
Why not removing the condition completly? Just "John von Neumann and John Smith and Black Brown, Peter"?
Similar comments for the other false checks.
lenhard
approved these changes
Aug 24, 2017
Closed
Siedlerchr
added a commit
that referenced
this pull request
Aug 27, 2017
* upstream/master: Add preference to disable validation in the entry editor by default (#3154) Fix freezing on browse in protected terms dialog when adding from entry editor (#3158) Close entry editor when the shown entry is removed externally (#3156) .jar are not ignored any more (#3155) Increase size of file and keywords editors (#3141) Make Replace Strings work in bibtexkeyfield Fix errorprone (#3151) Fix display of percentage symbol in entry preview (#3149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3151
Main problem: comments after a line are always assumed to be somehow named parameter arguments
Some Tests were not run (missing test annotation)
Some complex boolean expressions aka (0==1) where false should be used
Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef
Check documentation status (Issue created for outdated help page at help.jabref.org?)
If you changed the localization: Did you run
gradle localizationUpdate?