Implement drag and drop reordering in General files list #3194

Siedlerchr · 2017-09-03T15:22:49Z

Add drag and drop related methods to ViewModelFactory
Make LInkedFile serializeable
Fixes #3165 (comment)

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef
Check documentation status (Issue created for outdated help page at help.jabref.org?)
If you changed the localization: Did you run gradle localizationUpdate?

Add drag and drop related methods to ViewModelFactory Make LInkedFile serializeable

lenhard

The code looks fine and the reordering works.

However, JabRef does not remember that a file has been reordered. So when I start JabRef anew the files are back to their original order. Is that intented?

Siedlerchr · 2017-09-04T12:10:05Z

@lenhard Hm, that's odd. I will try to look at it. But I think it could be possible that there is no database changed event fired

* upstream/master: Update wiremock from 2.7.1 -> 2.8.0 Update log4j from 2.8.2 -> 2.9.0 Added the name of some new authors Fix typo Improvement in Japanese translation (#3193)

* upstream/master: Remove untranslated Strings from the greek menu translation Remove untranslated Strings from the greek translation Update wiremock from 2.7.1 -> 2.8.0 Update log4j from 2.8.2 -> 2.9.0 Added the name of some new authors Fix typo local db and shared db sync fix #2284 with changelog local db and shared db sync fix #2284 Improvement in Japanese translation (#3193)

…bibdb

Siedlerchr · 2017-09-05T16:48:43Z

@lenhard The new file ordering is now also changed in the bibtex data

koppor

Some minor code comments.

koppor · 2017-09-05T16:55:01Z

src/main/java/org/jabref/model/entry/LinkedFile.java

@@ -14,7 +15,8 @@
 /**
 * Represents the link to an external file (e.g. associated PDF file).
 */
-public class LinkedFile {
+//Serialiable is required for drag and drop


Why not a real class comment? I would always use the class comments.

koppor · 2017-09-05T16:55:24Z

src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java

@@ -113,6 +144,21 @@ protected void updateItem(T item, boolean empty) {
                    if (toContextMenu != null) {
                        setContextMenu(toContextMenu.call(viewModel));
                    }
+                    if (toOnDragDetected != null) {


Oh, wow, this code looks odd. Is JavaFX really like that?

koppor · 2017-09-05T17:00:52Z

I have following file entry in my bib entry:

file      = {:Cla2008 -The Birth of Model Checking.pdf:PDF},

It is rendered like this:

Does this come from this PR?

lenhard · 2017-09-05T17:30:41Z

I've tested it briefly with an entry with two file links and there reordering was possible and also stored between sessions.

Siedlerchr · 2017-09-05T18:11:01Z

src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java

@@ -76,6 +82,31 @@
        return this;
    }

+    public ViewModelListCellFactory<T> setOnDragDetected(BiConsumer<T, ? super MouseEvent> toOnDragDetected) {
+        this.toOnDragDetected = toOnDragDetected;


@koppor The null check refers to this factory function where it gets assigned

Siedlerchr · 2017-09-05T18:12:16Z

@koppor Your display thing is related to the autolinked file. One of your files got autolinked.

Siedlerchr · 2017-09-05T18:15:01Z

src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java

@@ -49,12 +56,67 @@ public LinkedFilesEditor(String fieldName, DialogService dialogService, BibDatab
                .withTooltip(LinkedFileViewModel::getDescription)
                .withGraphic(LinkedFilesEditor::createFileDisplay)
                .withContextMenu(this::createContextMenuForFile)
-                .withOnMouseClickedEvent(this::handleItemMouseClick);
+                .withOnMouseClickedEvent(this::handleItemMouseClick)


@koppor The BiConsumer stuff allows to do these fancy things

… dragdropfiles * 'dragdropfiles' of https://github.com/JabRef/jabref: remove empty line Make content binding bidirectional so changes are also recognized in bibdb Remove untranslated Strings from the greek menu translation Remove untranslated Strings from the greek translation local db and shared db sync fix #2284 with changelog local db and shared db sync fix #2284

* upstream/master: Update xmlunit from 2.4.0 -> 2.5.0 Fix tooltip for hotkey

koppor · 2017-09-05T18:26:37Z

Think, I've to open another issue. Why the hell is the same file linked twice? 😱 Am 05.09.2017 20:12 schrieb "Christoph" <notifications@github.com>:

…

@koppor <https://github.com/koppor> Your display thing is related to the autolinked file. One of your files got autolinked. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3194 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTafrSslcfRbbXfpeNWqUimgcu4XSmcks5sfY8DgaJpZM4PLNtG> .

Implemente drag and drop reordering in General files list

1f1dca7

Add drag and drop related methods to ViewModelFactory Make LInkedFile serializeable

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 3, 2017

koppor changed the title ~~Implemente drag and drop reordering in General files list~~ Implement drag and drop reordering in General files list Sep 4, 2017

Siedlerchr mentioned this pull request Sep 4, 2017

Can't remove or move online file link #3165

Closed

lenhard reviewed Sep 4, 2017

View reviewed changes

Siedlerchr added 4 commits September 4, 2017 18:46

Merge remote-tracking branch 'upstream/master' into dragdropfiles

a4bf5a8

* upstream/master: Update wiremock from 2.7.1 -> 2.8.0 Update log4j from 2.8.2 -> 2.9.0 Added the name of some new authors Fix typo Improvement in Japanese translation (#3193)

Make content binding bidirectional so changes are also recognized in …

4457ffe

…bibdb

remove empty line

b2f4672

koppor reviewed Sep 5, 2017

View reviewed changes

Siedlerchr commented Sep 5, 2017

View reviewed changes

Siedlerchr added 3 commits September 5, 2017 20:16

Merge remote-tracking branch 'upstream/master' into dragdropfiles

0430b05

* upstream/master: Update xmlunit from 2.4.0 -> 2.5.0 Fix tooltip for hotkey

move comment to class comment

e6fc143

Siedlerchr merged commit 647b382 into master Sep 5, 2017

Siedlerchr deleted the dragdropfiles branch September 5, 2017 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement drag and drop reordering in General files list #3194

Implement drag and drop reordering in General files list #3194

Siedlerchr commented Sep 3, 2017 •

edited

Loading

lenhard left a comment

Siedlerchr commented Sep 4, 2017

Siedlerchr commented Sep 5, 2017 •

edited

Loading

koppor left a comment

koppor Sep 5, 2017

koppor Sep 5, 2017

koppor commented Sep 5, 2017

lenhard commented Sep 5, 2017

Siedlerchr Sep 5, 2017

Siedlerchr commented Sep 5, 2017

Siedlerchr Sep 5, 2017

koppor commented Sep 5, 2017 via email

Implement drag and drop reordering in General files list #3194

Implement drag and drop reordering in General files list #3194

Conversation

Siedlerchr commented Sep 3, 2017 • edited Loading

lenhard left a comment

Choose a reason for hiding this comment

Siedlerchr commented Sep 4, 2017

Siedlerchr commented Sep 5, 2017 • edited Loading

koppor left a comment

Choose a reason for hiding this comment

koppor Sep 5, 2017

Choose a reason for hiding this comment

koppor Sep 5, 2017

Choose a reason for hiding this comment

koppor commented Sep 5, 2017

lenhard commented Sep 5, 2017

Siedlerchr Sep 5, 2017

Choose a reason for hiding this comment

Siedlerchr commented Sep 5, 2017

Siedlerchr Sep 5, 2017

Choose a reason for hiding this comment

koppor commented Sep 5, 2017 via email

Siedlerchr commented Sep 3, 2017 •

edited

Loading

Siedlerchr commented Sep 5, 2017 •

edited

Loading