Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework AutoSetFileLinks #3368

Merged
merged 14 commits into from
Oct 31, 2017
Merged

Rework AutoSetFileLinks #3368

merged 14 commits into from
Oct 31, 2017

Commits on Oct 28, 2017

  1. Rework AutoSetFileLinks

    @Siedlerchr
    Siedlerchr committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    61fb09f View commit details
    Browse the repository at this point in the history

  2. Only add first found file

    @Siedlerchr
    Siedlerchr committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    d03f155 View commit details
    Browse the repository at this point in the history

  3. Improve magic AutoFileLinking in entry editor by using same logic as … 

    …manually triggering it
    @Siedlerchr
    Siedlerchr committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    51fe583 View commit details
    Browse the repository at this point in the history

  4. Don't use paths.get

    @Siedlerchr
    Siedlerchr committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    0a305fe View commit details
    Browse the repository at this point in the history

  5. add changelog entry

    @Siedlerchr
    Siedlerchr committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    124bc37 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2017

  1. refactor 

    TODO: remove duplicate findings
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    8ab45cd View commit details
    Browse the repository at this point in the history

  2. Use HashMap with BibEntry and LinkedFiles 

    Only call setFiles when pressing F7
Fix javafx thread error
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    8aed0d0 View commit details
    Browse the repository at this point in the history

  3. improve optional code 

    use streams in externalfiletype
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    fd29758 View commit details
    Browse the repository at this point in the history

  4. logging 

    remove javadoc params
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    12f21bf View commit details
    Browse the repository at this point in the history

  5. pass preferences to method

    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    fff82ea View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into autofilelink 

    * upstream/master:
  Refactorings (#3370)

# Conflicts:
#	src/main/java/org/jabref/gui/externalfiles/AutoSetLinks.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    1e16b17 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into autofilelink 

    * upstream/master:
  revert wrongly commited changes

# Conflicts:
#	src/main/java/org/jabref/gui/externalfiles/AutoSetLinks.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
    @Siedlerchr
    Siedlerchr committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    1948112 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. Return list of Linkedfiles and let caller handle bib entries 

    Add test
    @Siedlerchr
    Siedlerchr committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    229ce64 View commit details
    Browse the repository at this point in the history

  2. Replace mocking of Jabrefs prefs with autolink prefs

    @Siedlerchr
    Siedlerchr committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    05fa33f View commit details
    Browse the repository at this point in the history