Fix problems in source editor #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
6 tasks
|
Looks good to be, however I am wondering why the javafx thread check did not work as specified? |
|
It worked...if the call were made on the javafx thread, then the runnable was send to the executor. However, the executor starts a new thread for each submitted task. |
|
I tested it locally and apart from getting any error hint on invalid bibtex (which is simply reverted) it works as expected. So I merge this in now |
Siedlerchr
added a commit
that referenced
this pull request
Nov 4, 2017
* upstream/master: (26 commits) Fix static localized text (#3400) Fix problems in source editor (#3398) Fix MathSciNet fetcher (#3402) Fix NPE when saving new file Improve SyncLang.py (#3184) Config intellj code style to adhere to empty lines checkstyle rule (#3365) Don't list same look and feels more than once (#3393) progessdialog and result table are now shown correclty on copy files Export pdf/linked files (#3147) Added checking integrity dialog (#3388) Update richtext and flowless (#3386) Source tab: hide notification pane when code is correct again (#3387) Titles are optional at crossref (#3378) Update entry for every change in the source panel (#3366) Rework AutoSetFileLinks (#3368) revert wrongly commited changes Refactorings (#3370) Fix freezing when running cleanup file operations like rename (#3315) This additional style setting for IDEA (#3355) Fix checkstyle ... # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here is now a real fix of these problems in the source editor (index out of bounds, paste, select all, update,...). The problem was that updates to the editor were not performed on the javafx thread although they were wraped in a
runInJavaFXThreadcall. The reason was that this method would actually submit tasks to the executor, which would then start a new thread. So the fix only happens inDefaultTaskExecutor, the rest of the changes are minor cosmetic improvements to get rid of globals or base panels in the source tab.gradle localizationUpdate?