Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding for DOI import #34

Merged
merged 2 commits into from
Dec 7, 2014
Merged

Fix encoding for DOI import #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5cd64
Fix encoding for DOI import
bquistorff Dec 5, 2014
a352170
+Contribution notes for DOI encoding fix
bquistorff Dec 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[master]
- Fix for bug 1213 (sourceforge): Fix encoding for DOI import
- Feature #809: import pubmed central id (pmc) field from medline
- Fix undoing Cleanup/Convert to Biblatex
- Adapted pattern to parse DBLP entries
Expand Down
8 changes: 5 additions & 3 deletions src/main/java/net/sf/jabref/imports/DOItoBibTeXFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright (C) 2012 JabRef contributors.
/* Copyright (C) 2014 JabRef contributors.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
Expand Down Expand Up @@ -119,7 +119,7 @@ public BibtexEntry getEntryFromDOI(String doi, OutputPrinter status) {

String bibtexString;
try {
bibtexString = Util.getResults(conn);
bibtexString = Util.getResultsWithEncoding(conn, "UTF8");
} catch (FileNotFoundException e) {

if (status != null) {
Expand All @@ -134,7 +134,9 @@ public BibtexEntry getEntryFromDOI(String doi, OutputPrinter status) {
}



//Usually includes an en-dash in the page range. Char is in cp1252 but not
// ISO 8859-1 (which is what latex expects). For convenience replace here.
bibtexString = bibtexString.replaceAll("(pages=\\{[0-9]+)\u2013([0-9]+\\})", "$1--$2");
BibtexEntry entry = BibtexParser.singleFromString(bibtexString);

if (entry != null) {
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/help/About.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ <h2>Contributions from:</h2>
Alex Montgomery,
Saverio Mori,
Ambrogio Oliva,
Brian Quistorff,
Stephan Rave,
John Relph,
Hannes Restel,
Expand Down