Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of syncLang to python2 #3420

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Backport of syncLang to python2 #3420

merged 2 commits into from
Nov 9, 2017

Conversation

LinusDietz
Copy link
Member

@LinusDietz LinusDietz commented Nov 9, 2017 •
edited
Loading

fixes #3414,

makes #3415 obsolete...

@LinusDietz LinusDietz added build-system internationalization i18n status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 9, 2017
@LinusDietz LinusDietz requested a review from koppor November 9, 2017 11:35
@LinusDietz LinusDietz mentioned this pull request Nov 9, 2017
Closed
lenhard
lenhard approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./gradlew localizationUpdate works on my machine and if I add a new key to the english language file it gets copied to the other ones as well.

Good job :)

@halirutan
Copy link
Collaborator

I tested it locally and it works for me as well. Can we merge this to master so that other work is not stalled?

@LinusDietz LinusDietz merged commit 732d358 into master Nov 9, 2017
@LinusDietz LinusDietz deleted the synclang-python2-backport branch November 9, 2017 14:10
Siedlerchr added a commit that referenced this pull request Nov 10, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
fac2c3d 
* upstream/master: (26 commits)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this pull request Nov 18, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into linuxlink
b60fbfe 
* upstream/master: (23 commits)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this pull request Nov 19, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
dbca24f 
* upstream/master: (30 commits)
  Add Hint for checking master version (#3439)
  Replace LinkedFiles backslashes with forward slashes (#3403)
  fix isbn result from chimbori (#3442)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
build-system internationalization i18n status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in SyncLang.py
3 participants
@LinusDietz @halirutan @lenhard