Replace swingx with standard swing #3454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to properly move to Java 9 (see #2594), we need to get rid of all accesses of internal APIs. Unfortunately, we also use libraries that make such internal accesses and we need to find a solution for that.
One of these libraries is swingx. Originally by Sun, it is no longer maintained since quite a while we could not even upgrade to the newest version, because of bugs in the library. It is time to get rid of this dependency. This PR replaces the usage of swingx with regular Swing components. Only the new entries dialog and the side pane are affected. For the new entries dialog, the change is trivial (just using a regular layout manager). For the side pane, a few changes are needed, but I can make it roughly resemble the old layout.
There's one bigger change, though, that I happen to like very much: The side panes are no longer exclusive, you can display them together. That means that I can have the web search and the groups panel open at the same time. Personally, I think that's pretty cool and I would like to keep it that way. You can of course still disable the side panes independent of each other. Here's a screenshot:
gradle localizationUpdate
?