Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace swingx with standard swing #3454

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Replace swingx with standard swing #3454

merged 2 commits into from
Nov 24, 2017

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Nov 24, 2017

In order to be able to properly move to Java 9 (see #2594), we need to get rid of all accesses of internal APIs. Unfortunately, we also use libraries that make such internal accesses and we need to find a solution for that.

One of these libraries is swingx. Originally by Sun, it is no longer maintained since quite a while we could not even upgrade to the newest version, because of bugs in the library. It is time to get rid of this dependency. This PR replaces the usage of swingx with regular Swing components. Only the new entries dialog and the side pane are affected. For the new entries dialog, the change is trivial (just using a regular layout manager). For the side pane, a few changes are needed, but I can make it roughly resemble the old layout.

There's one bigger change, though, that I happen to like very much: The side panes are no longer exclusive, you can display them together. That means that I can have the web search and the groups panel open at the same time. Personally, I think that's pretty cool and I would like to keep it that way. You can of course still disable the side panes independent of each other. Here's a screenshot:
sidepane


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 24, 2017
@lenhard lenhard changed the title Remove swingx Replace swingx with standard swing Nov 24, 2017
@Siedlerchr
Copy link
Member

Yeah! Cool, pretty good work!

@LinusDietz LinusDietz merged commit 8025c69 into master Nov 24, 2017
@LinusDietz LinusDietz deleted the remove-swingx branch November 24, 2017 11:27
@matthiasgeiger
Copy link
Member

There's one bigger change, though, that I happen to like very much: The side panes are no longer exclusive, you can display them together. That means that I can have the web search and the groups panel open at the same time.

This was already possible before 😉

@lenhard
Copy link
Member Author

lenhard commented Nov 24, 2017

Huh? Good to know, then at least no one can blame it on me when something related to that breaks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants