Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \textquotesingle to the html conversion table #3487

Merged
merged 4 commits into from
Dec 5, 2017
Merged

Add \textquotesingle to the html conversion table #3487

merged 4 commits into from
Dec 5, 2017

Conversation

psychelzh
Copy link
Contributor

@psychelzh psychelzh commented Dec 5, 2017

LaTex use various escape strings to denote certain symbols. Here I add {\textquotesingle} to the html conversion table, which represents apostrophe (').


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@psychelzh
Copy link
Contributor Author

Add one more symbol. Related to #3307

koppor
koppor previously approved these changes Dec 5, 2017
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 5, 2017
@@ -475,6 +475,7 @@
{"36", "dollar", "\\$"}, // Dollar
{"37", "#37", "\\%"}, // Percent (% is not displayed correctly in the entry preview)
{"39", "apos", "'"}, // Apostrophe
{"39", "apos", "{\\textquotesingle}"}, // Apostrophe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't think this is going to work this way. This clashes with the already existing mapping for unicode value 39 in the line above and will lead to unpredictable results later.

I think it would be better to add the conversion as part of the "manual additions" to LATEX_HTML_CONVERSION_MAP and LATEX_UNICODE_CONVERSION_MAP , like for the relax term. This should have the same effect, but it avoids the clash for the other maps.

Copy link
Contributor Author

@psychelzh psychelzh Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how can it be done? I just do not know the details. I think of {\textquotesingle} as an alias of '.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at lines 897 and 898 in the same class. You can add the symbol in the very same way.

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 5, 2017
@koppor koppor dismissed their stale review December 5, 2017 10:06

@lenhard is right with his comments.

@lenhard
Copy link
Member

lenhard commented Dec 5, 2017

Thanks, perfect now :) I'll merge directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants