Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in search bar #3497

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Fix NPE in search bar #3497

merged 2 commits into from
Dec 8, 2017

Conversation

tobiasdiez
Copy link
Member

In #3471 a NPE was mentioned. I'm not sure which object was null (it should not be the scene, since this is just set and the css file should also be always found). Moreover, I could not reproduce the exception, so this fix is a shot in the blue.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 8, 2017
@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 8, 2017

Seems like this could be a LInux thing and related to our customjfx panel, see also the log in #3500

Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, code-wise this are just minor changes, so you can merge if you think it's ready.

It would be better, though, if we knew that it actually fixes the problem.

@tobiasdiez
Copy link
Member Author

I merge it now since it is still a slight improvement over the existing code. I'll have a look at the azure reports if a similar exception gets reported in the next days.

@tobiasdiez tobiasdiez merged commit c51ecbe into master Dec 8, 2017
@tobiasdiez tobiasdiez deleted the fix3471 branch December 8, 2017 22:14
Siedlerchr added a commit that referenced this pull request Dec 9, 2017
* upstream/master:
  Fix NPE in search bar (#3497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants