Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #3491: Clicking the PDF icon in the linked files editor opens the file #3508

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

tobiasdiez
Copy link
Member

Resolves #3491. A click on the PDF icon on a linked file in the entry editor opens the file. This is consistent with the behavior in the main table and thus I didn't added a new button and / or changed the double-click behavior as it was suggested in the issue.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 10, 2017
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beautifully simple code change :)

So one click opens the PDF and a double click opens the modify file dialog. Sounds fine by me.

@Siedlerchr
Copy link
Member

That's a nice solution. Btw, do you have any idea why the second file in the listvie does not indicate the blue selection ? Although it is selected

@Siedlerchr Siedlerchr merged commit a9c5ed5 into master Dec 10, 2017
@tobiasdiez
Copy link
Member Author

@lenhard The beauty of JavaFX!
@Siedlerchr No idea. Similarly, there are these annoying padding problems of the first row. The "beauty" of JavaFX! 😄

@tobiasdiez tobiasdiez deleted the fix3491 branch December 10, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants