Test for InspecImporter #356

mairdl · 2015-11-17T12:30:59Z

Completed code coverage and discovered a bug in BibtexEntryType (BibtetEntryType.getType() ALL_TYPES.get() returns null)

simonharrer · 2015-11-17T12:52:43Z

src/test/java/net/sf/jabref/importer/fileformat/InspecImportTest.java

+    @Test
+    public void testImportEntries3() {
+
+        InputStream inStream = InspecImportTest.class.getResourceAsStream("InspecImportTest4.txt");


try-with-resources please to ensure that the input stream is closed.

simonharrer · 2015-11-17T12:56:40Z

src/test/java/net/sf/jabref/importer/fileformat/InspecImportTest.java

+        Assert.assertTrue("InspecImporter isRecognizedFormaTrue test failed",
+                inspecImp.isRecognizedFormat(inStream));
+        Assert.assertFalse("InspecImporter isRecognizedFormatFalse test failed",
+                inspecImp.isRecognizedFormat(inStream));


Have a look at #310 for handling the tests for format recognition.

I editet the format recognition, so that it equals the one of #310

Hm, I do not see this in the current PR.

My bad I understood it the wrong way. I'll fix it in the next commit.

mairdl · 2015-11-19T14:50:13Z

It seems like my commits have some issues, but I don't get the problem. Can someone help me out?

oscargus · 2015-11-19T15:31:17Z

I do not think it is your commit that causes problems. For some reason the SpringerLinkFetch test fails.

koppor · 2015-11-24T19:25:15Z

@mairdl I think, it would make sense if you squash all commits into a single commit and to a git push -f. You could also do a git rebase master as described at #379 (comment). After having done that, the rest by CircleCI should not fail any more.

tobiasdiez · 2015-12-28T17:03:41Z

src/test/java/net/sf/jabref/importer/fileformat/InspecImportTest.java

+
+    @Before
+    public void setUp() throws Exception {
+        if (Globals.prefs == null) {


If statement not necessary.

Braunch · 2016-03-14T13:09:48Z

Is it ready for a merge now?

tobiasdiez · 2016-03-14T13:50:09Z

testCompleteBibtexEntryOnJournalPaperImport still has one not addressed comment. Please rename the commit to something more meaning full like Test for InspecImporter. Other than that 👍 for merge.

simonharrer · 2016-03-15T10:20:01Z

src/test/java/net/sf/jabref/importer/fileformat/InspecImportTest.java

+            inStream.close();
+            assertEquals(1, entries.size());
+            BibEntry entry = entries.get(0);
+            assertEquals(BibtexEntryTypes.INPROCEEDINGS.getName().toLowerCase(), entry.getType());


Replace this with BibtexEntryAssert.assertEquals(Arrays.ListOf(shouldBeEntry), entries) as well.

Are you sure you mean "Arrays.ListOf(shouldBeEntry)"? Because I can't find this method.

Simon meant the Arrays.asList, but Collections.singletonList also works (I think IntelliJ even suggest replacing asList with singletonList)

If i try to solve it with Arrays.asList or with Collections.singletonList, I get an error from the assertion because I try to compare a list of BibEntry with a BibEntry.

But entries is a list, isn't it?

entries is a BibEntry as suggested in earlier comments

Please reference the comment. You can get the deep link to a comment using the time given at a commit. While scrolling through here, I don't see that comment directly. Please help the reader by clear references.

@koppor Here you go comment

koppor · 2016-03-18T16:42:48Z

@Braunch: I don't know, what you did, but all commits seem to be lost. Please use gitk to investigate and ask someone else (@mairdl?) if he still has a local copy. He should NOT delete his local code. If all of you deleted it, you have to use the hard man git tooling and look for: git reflog is your friend. See for example at http://gitready.com/advanced/2009/01/17/restoring-lost-commits.html.

mairdl · 2016-03-18T19:54:32Z

@koppor I think Chris(braunch) squashed all commits into 1

koppor · 2016-03-18T22:12:05Z

@mairdl It looks like follows on my site:

10ffb1c is a~~n empty commit~~ huge commit and 3e4c73c shows a removal of empty lines. Where is the single commit you are talking about?

mairdl · 2016-03-18T23:15:49Z

@koppor Now i understand what you mean, my bad. I'll contact @Braunch.

Braunch · 2016-03-27T13:52:14Z

I hope my last commit fixed that. Otherwise I am doing something wrong with git.

stefan-kolb · 2016-03-30T13:46:57Z

Tests are failing, please investigate.

mairdl · 2016-03-31T15:43:42Z

Now the tests are working

stefan-kolb · 2016-04-06T18:09:42Z

@tobiasdiez @koppor @simonharrer Are you happy enough with it now? We can squash the commits via the merge button.

tobiasdiez · 2016-04-06T18:57:57Z

src/test/java/net/sf/jabref/importer/fileformat/InspecImportTest.java

+
+        try (InputStream inStream = new ByteArrayInputStream(testInput.getBytes())) {
+            List<BibEntry> entries = inspecImp.importEntries(inStream, new OutputPrinterToNull());
+            assertEquals(1, entries.size());


Use BibtexEntryAssert.assertEquals(Collections.singletonList(shouldbeEntry), entries);

simonharrer · 2016-04-07T07:34:52Z

Interesting that the code coverage decreases according to codecov by 0.85% in a PR which aims to increase test coverage. Very strange.

oscargus · 2016-04-07T12:34:15Z

I think it is because the code in this PR is based on an older code base, so fewer tests included and the comparison is against the (at the time of the push) current master. Push again and it would decrease > 2%...

mairdl and others added 7 commits November 9, 2015 13:15

Create the test class of the InspecImporter

f56e689

Simple comment correction

c8ba49e

Completed testcases: testGetFormatName, testGetCLIId

6d0e813

Merge branch 'master' of https://github.com/Braunch/jabref

15ee8f7

Added an empty testfile for inspec import test

d8c61e2

Created testRecognizedformat test for ispec importer

180db7e

Changed example file for inspec import test

70ce056

simonharrer reviewed Nov 17, 2015
View reviewed changes

simonharrer added stupro labels Nov 17, 2015

simonharrer reviewed Nov 17, 2015
View reviewed changes

Merge remote-tracking branch 'upstream/master'

8bbc6c2

mairdl force-pushed the InspecImportTest branch from 39632d9 to c3e172c Compare December 14, 2015 17:46

Merge remote-tracking branch 'upstream/master'

e8d6e6e

mairdl force-pushed the InspecImportTest branch from eb26272 to 5adaf0d Compare December 21, 2015 12:45

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 21, 2015

tobiasdiez reviewed Dec 28, 2015
View reviewed changes

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 15, 2016

koppor changed the title ~~Test for InspecImporter~~ [WIP] Test for InspecImporter Jan 15, 2016

Braunch force-pushed the InspecImportTest branch from 5adaf0d to a860ffc Compare February 8, 2016 16:53

Braunch force-pushed the InspecImportTest branch from 5062305 to 3a0e16e Compare March 13, 2016 11:36

Braunch force-pushed the InspecImportTest branch from 5335afe to f9fd308 Compare March 14, 2016 15:42

simonharrer reviewed Mar 15, 2016
View reviewed changes

Merge remote-tracking branch 'upstream/master'

672144f

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 18, 2016

Braunch force-pushed the InspecImportTest branch from 3e4c73c to 5d6980c Compare March 27, 2016 13:50

mairdl force-pushed the InspecImportTest branch 2 times, most recently from 49ff62c to 5846469 Compare April 3, 2016 18:02

Added InspecImportTest and testfiles with minor changes to InspecImport

bd33762

mairdl force-pushed the InspecImportTest branch from 5846469 to bd33762 Compare April 3, 2016 18:07

tobiasdiez reviewed Apr 6, 2016
View reviewed changes

simonharrer merged commit 6671a44 into JabRef:master Apr 7, 2016

koppor mentioned this pull request Apr 13, 2016

MedlineImporterTest #547

Merged

Braunch deleted the InspecImportTest branch September 5, 2016 10:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test for InspecImporter #356

Test for InspecImporter #356

mairdl commented Nov 17, 2015

simonharrer Nov 17, 2015

simonharrer Nov 17, 2015

mairdl Nov 18, 2015

simonharrer Nov 18, 2015

mairdl Nov 19, 2015

mairdl commented Nov 19, 2015

oscargus commented Nov 19, 2015

koppor commented Nov 24, 2015

tobiasdiez Dec 28, 2015

Braunch commented Mar 14, 2016

tobiasdiez commented Mar 14, 2016

simonharrer Mar 15, 2016

mairdl Mar 17, 2016

tobiasdiez Mar 17, 2016

mairdl Mar 18, 2016

tobiasdiez Mar 18, 2016

mairdl Mar 18, 2016

koppor Mar 18, 2016

mairdl Mar 18, 2016

koppor commented Mar 18, 2016

mairdl commented Mar 18, 2016

koppor commented Mar 18, 2016

mairdl commented Mar 18, 2016

Braunch commented Mar 27, 2016

stefan-kolb commented Mar 30, 2016

mairdl commented Mar 31, 2016

stefan-kolb commented Apr 6, 2016

tobiasdiez Apr 6, 2016

simonharrer commented Apr 7, 2016

oscargus commented Apr 7, 2016

Test for InspecImporter #356

Test for InspecImporter #356

Conversation

mairdl commented Nov 17, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mairdl commented Nov 19, 2015

oscargus commented Nov 19, 2015

koppor commented Nov 24, 2015

Choose a reason for hiding this comment

Braunch commented Mar 14, 2016

tobiasdiez commented Mar 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Mar 18, 2016

mairdl commented Mar 18, 2016

koppor commented Mar 18, 2016

mairdl commented Mar 18, 2016

Braunch commented Mar 27, 2016

stefan-kolb commented Mar 30, 2016

mairdl commented Mar 31, 2016

stefan-kolb commented Apr 6, 2016

Choose a reason for hiding this comment

simonharrer commented Apr 7, 2016

oscargus commented Apr 7, 2016