Bring back the context menu #3666
Conversation
tobiasdiez
added
status: ready-for-review
| */ | ||
| public class OldCommandWrapper extends CommandBase { | ||
|
|
||
| private static final Log LOGGER = LogFactory.getLog(OldCommandWrapper.class); |
There was a problem hiding this comment.
Please use the new logging private static final Logger LOGGER = LoggerFactory.getLogger(OldCommandWrapper.class);
There was a problem hiding this comment.
Your PR is not yet merged into javafxTable and I prefer to do this as soon as all the other maintable PRs are merged
There was a problem hiding this comment.
Okay, just as a hint to make work then easier. Slf4j has a nice migrator tool (inlcuded in the zip download) https://www.slf4j.org/migrator.html to replace all occurences. Used that for the migration, too.
|
|
@Siedlerchr Thank you for the feedback. I implemented your suggestions accordingly. |
|
Can't we have an "Edit" submenu here containing all the edit actions available? For me, this conforms to "Lernförderlichkeit" and "Erwartungskonformität" from EN ISO 9241-110 Grundsätze der Dialoggestaltung. Especially the "Erwawrungskonformität", because I expect that all actions available for the current entry are available in the context menu. |
Removed a few commands that are not needed often and thus don't need to be placed that prominently.
Changes in the architecture:
Actiondefined both the visual properties (text, icons, ...) as well as the behavior. These actions are usually defined in the base panel (or main frame).ActionFX(to be renamed toActionas soon as the old class can be removed) and the behavior by implementing theCommandinterface. This separation makes it possible to reuse the visual aspects without the ties to the behavior.