Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set main stage for file dialogs #3790

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Conversation

tobiasdiez
Copy link
Member

Sets the correct parent for the file dialogs so that these are now modal.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 28, 2018
@Siedlerchr
Copy link
Member

I think you have selected the wrong base branch or did you intend to merge it into the telemetry branch?

@stefan-kolb
Copy link
Member

Ah this should fix some open issues (or at least one)?!

@tobiasdiez tobiasdiez changed the base branch from telementryCommands to maintable-beta March 1, 2018 16:03
@tobiasdiez
Copy link
Member Author

tobiasdiez commented Mar 1, 2018

@Siedlerchr yeah, my bad. I now changed it to the correct base branch (and now the telemetry commit pops up as a new change...Tobi and git).
@stefan-kolb good observation, I was not aware that this was reported previously. Yes, this PR should fix #3410. I'll add it to the changelog in #3621 as soon as this PR gets merged.

@Siedlerchr Siedlerchr merged commit f4f527d into maintable-beta Mar 2, 2018
@Siedlerchr Siedlerchr deleted the dialogMainWindowNew branch March 2, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants