Restructure startup #4054
Merged
Restructure startup #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
Siedlerchr
approved these changes
May 24, 2018
tobiasdiez
reviewed
May 24, 2018
| /** | ||
| * Perform checks and changes for users with a preference set from an older JabRef version. | ||
| */ | ||
| private static void migratePreferences() { |
There was a problem hiding this comment.
Move to PreferencesMigrations ?
tobiasdiez
approved these changes
May 24, 2018
koppor
reviewed
May 25, 2018
|
|
||
| // See if we should shut down now | ||
| if (argumentProcessor.shouldShutDown()) { | ||
| Globals.shutdownThreadPools(); |
There was a problem hiding this comment.
This code is appearing twice, too. Can it be moved to shutdownCurrentInstance()?
Alternatively, change line this line to
if (!allowMultipleAppInstances(args) || argumentProcessor.shouldShutDown()) {
and remove the shutdown code from allowMultipleAppInstances.
| .invokeLater(() -> new JabRefGUI(argumentProcessor.getParserResults(), argumentProcessor.isBlank())); | ||
| } | ||
|
|
||
| private static boolean allowMultipleAppInstances(String[] args) { |
There was a problem hiding this comment.
Rename that to handleMultipleInstances, because some "black magic" is happening here. Nut just a check whether multiple instances are allowed.
|
@stefan-kolb may I ask you to merge the master now also into the maintable-beta branch. You are more familiar with the changes to the startup code than me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considered as necessary when reviewing #4047