Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac graphics #4074

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Mac graphics #4074

merged 3 commits into from
Jun 7, 2018

Conversation

stefan-kolb
Copy link
Member

Resolves #4070

@LinusDietz @halirutan Can you also take a look as you own a mac, please 😄

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 2, 2018
@stefan-kolb
Copy link
Member Author

Should also be backported to v4.x

@halirutan
Copy link
Collaborator

@stefan-kolb I certainly can test something, but what exactly should I look out for? With JabRef open, should my Macbook use the integrated graphics-card or the fast one? Or should I only test if JabRef works?

@stefan-kolb
Copy link
Member Author

It should use the integrated card.

@jcrbloch
Copy link

jcrbloch commented Jun 7, 2018

FYI: I just upgraded from Jabref 4.2 to 4.3.1. I had to correct the plist again to have jabref use the integrated graphics card, see #4070. So I guess that we are just waiting for your corrections to be merged.

@halirutan
Copy link
Collaborator

It seems to work. My Activity Monitor says that JabRef does not require high-performance GPU. Is there anything else I should look out for?

@stefan-kolb
Copy link
Member Author

I guess that's it. @LinusDietz

@jcrbloch
Copy link

jcrbloch commented Jun 7, 2018 via email

@stefan-kolb stefan-kolb merged commit 66afd42 into master Jun 7, 2018
@stefan-kolb stefan-kolb deleted the mac-graphics branch June 7, 2018 15:01
stefan-kolb added a commit that referenced this pull request Jun 7, 2018
* Resolves #4070 Mac graphics

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Jun 8, 2018
* upstream/master:
  Mac graphics (#4074)
  The textarea in the PersonsEditor is focused when the field is focused (#4112)
  Fix that sometimes an empty side pane is shown (#4105)
Siedlerchr added a commit that referenced this pull request Jun 13, 2018
* upstream/master:
  Extract v4.x changelog (#4125)
  Saves and reloads window state on close and on open (#4124)
  Fix convert to bibtex moves contents of the file field (#4123)
  Opens the directory of the currently edited file when opening a new file (#4106)
  Show Citation style also in entry preview in preferences (#4121)
  Mac graphics (#4074)
  The textarea in the PersonsEditor is focused when the field is focused (#4112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants