-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum java to 171 #4095
Set minimum java to 171 #4095
Conversation
Let me check if the fix is already included in _171 |
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8195830 Unfortunately this is only fixed in 8u172 b01. Results:8u151: OK Unfortunately, I cannot find any information about v171. |
For provenance: This downgrades the minimum Java version introduced at #4058. |
Have you looked at the oracle changelog page for 171? Where you download the jdk there is a changelog linked. It could be that 171 only includes security fixes |
For a quick try out: Deep link to the Changelog:
The Changelog of 172 shows:
However, JDK-8033530 is not listed in the Changelog for 171. I would assume nevertheless that this issue is fixed in 171. See #4058 (comment). |
Ok, I have also tried to reproduce the bug with v171 and the code from https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8195830. Cannot see any spikes right now. We cannot be 100% sure as it is not in the changelog, but maybe it is worth risking it until v172 is rolled out everywhere. i guess we should still force v172 later on. |
* Reduce min java version to 171
Backported to v4.x at 3f73e9e. |
* Reduce min java version to 171 # Conflicts: # CHANGELOG.md
* upstream/master: (130 commits) Update gradle from 4.7 to 4.8 (#4102) Add gradle task downloadDependencies and use it at CircleCI (#4091) Set minimum java to 171 (#4095) Also use https in the CHANGELOG itself Add missing CHANGELOG entry Fix localiazation test Use official TempFolder extension for JUnit 5 tests Remove menu* from crowdin.yml (#4094) Merge recent changes to exporter/importer Add missing CHANGELOG entry New translations JabRef_en.properties (Vietnamese) New translations JabRef_en.properties (Dutch) New translations JabRef_en.properties (French) New translations JabRef_en.properties (German) New translations JabRef_en.properties (Greek) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Italian) New translations JabRef_en.properties (Japanese) New translations JabRef_en.properties (Danish) New translations JabRef_en.properties (Norwegian) ... # Conflicts: # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/PreviewPanel.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java
* upstream/master: (89 commits) Fix that sometimes an empty side pane is shown (#4105) Update gradle from 4.7 to 4.8 (#4102) Add gradle task downloadDependencies and use it at CircleCI (#4091) Set minimum java to 171 (#4095) Also use https in the CHANGELOG itself Add missing CHANGELOG entry Fix localiazation test Use official TempFolder extension for JUnit 5 tests Remove menu* from crowdin.yml (#4094) Merge recent changes to exporter/importer Add missing CHANGELOG entry New translations JabRef_en.properties (Vietnamese) New translations JabRef_en.properties (Dutch) New translations JabRef_en.properties (French) New translations JabRef_en.properties (German) New translations JabRef_en.properties (Greek) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Italian) New translations JabRef_en.properties (Japanese) New translations JabRef_en.properties (Danish) ... # Conflicts: # src/main/java/org/jabref/gui/shared/ConnectToSharedDatabaseDialog.java
Fixes #4093. Since Java does not automatically update to 171, users have to manually install the 172 update. This is very convenient.
I actually propose to cherry-pick this PR to 4.x and immediately release 4.3.1.