Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Save logic #4173 #4193

Closed
wants to merge 1 commit into from
Closed

[WIP] Save logic #4173 #4193

wants to merge 1 commit into from

Conversation

stefan-kolb
Copy link
Member

@stefan-kolb stefan-kolb commented Jul 12, 2018

#4173
Save logic is fundamentally flawed imho 😢

Without a status bar, we have no more possibility to signal problems to the user (it is debatable if the status bar was the right place for errors anyway).
Or at least a lot of the problems are swallowed right now.

@tobiasdiez
Copy link
Member

You can always use DialogService.showErrorMessage to notify the user about errors (i.e throw error in logic and catch it in the ui).

The fix looks good, but I'm asking myself we actually need a lock file in the first place...sounds so ancient to me.

@stefan-kolb
Copy link
Member Author

The entire save logic looks wierd. I just scratched the surface.

@tobiasdiez
Copy link
Member

I guess this is now surpassed by #4309.

@tobiasdiez tobiasdiez closed this Sep 13, 2018
@stefan-kolb stefan-kolb deleted the save branch October 10, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants