Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 3959: migrate all tests to JUnit 5 #4260

Merged
merged 76 commits into from
Aug 16, 2018
Merged

Fix for issue 3959: migrate all tests to JUnit 5 #4260

merged 76 commits into from
Aug 16, 2018

Commits on Aug 6, 2018

  1. Update migrate from JUnit 4 to JUnit 5

    @1160300305
    1160300305 committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    5d73b71 View commit details
    Browse the repository at this point in the history

  2. Update migrate from JUnit 4 to JUnit 5

    @1160300305
    1160300305 committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    cb1b75f View commit details
    Browse the repository at this point in the history

  3. Trying to change git accounts on my laptop

    @1160300305
    1160300305 committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    45fa771 View commit details
    Browse the repository at this point in the history

  4. Trying to change git accounts on my laptop

    @1160300305
    1160300305 committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    ddc898d View commit details
    Browse the repository at this point in the history

  5. Trying to change git accounts on my laptop

    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    553c7b4 View commit details
    Browse the repository at this point in the history

  6. Using static assert methods.

    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    f481f04 View commit details
    Browse the repository at this point in the history

  7. Migrate from JUnit 4 to JUnit 5 

    *AuthorListParameterTest.java
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    897131d View commit details
    Browse the repository at this point in the history

  8. Migrate from JUnit 4 to JUnit 5 

    *XmpUtilWriterTest.java
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    1e0c89e View commit details
    Browse the repository at this point in the history

  9. Migrate from JUnit 4 to JUnit 5 

    *XmpUtilReaderTest.java
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    1edf14f View commit details
    Browse the repository at this point in the history

  10. Migrate from JUnit 4 to JUnit 5 

    *SearchQueryHighlightObservableTest.java

    -did not use MockitoExtension.class as its official version has not been released yet.
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    5a34921 View commit details
    Browse the repository at this point in the history

  11. Migrate from JUnit 4 to JUnit 5 

    *CitationEntryTest.java
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    d23dc9c View commit details
    Browse the repository at this point in the history

  12. Migrate from JUnit 4 to JUnit 5 

    *RTFCharsTest.java
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    35e7621 View commit details
    Browse the repository at this point in the history

  13. Migrate from JUnit 4 to JUnit 5 

    *ProtectedTermsLoaderTest.java

    -When running tests, outputs in command line are different. I don't know if this change is correct.
    @Metatronwings
    Metatronwings committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    1c4022e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Trying to change to a new branch.

    @Metatronwings
    Metatronwings committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    2e63dc1 View commit details
    Browse the repository at this point in the history

  2. commit_test

    @HITTOM
    HITTOM committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    959fd13 View commit details
    Browse the repository at this point in the history

  3. delete my meaningless txt

    @HITTOM
    HITTOM committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    355a71d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2018

  1. Migrate from JUnit 4 to JUnit 5 

    *AuthorAndToSemicolonReplacerTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    9fc98e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-for-issue-3959' of https://github.com/Metatronwings… 

    …/jabref
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    3533b6b View commit details
    Browse the repository at this point in the history

  3. Migrate from JUnit 4 to JUnit 5 

    *FileDialogConfigurationTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    f74f486 View commit details
    Browse the repository at this point in the history

  4. Migrate from JUnit 4 to JUnit 5 

    *IntegrityCheckTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    a1df42f View commit details
    Browse the repository at this point in the history

  5. Migrate from JUnit 4 to JUnit 5 

    *ModsExportFormatTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    970502a View commit details
    Browse the repository at this point in the history

  6. Migrate from JUnit 4 to JUnit 5 

    *AutoSetFileLinksUtilTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    b18c9ba View commit details
    Browse the repository at this point in the history

  7. Migrate from JUnit 4 to JUnit 5 

    *MsBibExportFormatTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    fb157f4 View commit details
    Browse the repository at this point in the history

  8. Migrate from JUnit 4 to JUnit 5 

    *CsvExportFormatTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    7761b29 View commit details
    Browse the repository at this point in the history

  9. Migrate from JUnit 4 to JUnit 5 

    *HtmlExportFormatTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    aeee7ef View commit details
    Browse the repository at this point in the history

  10. Migrate from JUnit 4 to JUnit 5 

    *HtmlExportFormatTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    119f491 View commit details
    Browse the repository at this point in the history

  11. Migrate from JUnit 4 to JUnit 5 

    *RenamePdfCleanupTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    dbf6341 View commit details
    Browse the repository at this point in the history

  12. Migrate from JUnit 4 to JUnit 5 

    *ProtectedTermsListTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    8d3c78e View commit details
    Browse the repository at this point in the history

  13. Migrate from JUnit 4 to JUnit 5 

    *MoveFilesCleanupTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    21e539a View commit details
    Browse the repository at this point in the history

  14. Migrate from JUnit 4 to JUnit 5 

    *ImporterTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    3b0c544 View commit details
    Browse the repository at this point in the history

  15. Migrate from JUnit 4 to JUnit 5 

        *ExporterTest.java
    @Metatronwings
    Metatronwings committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    37a0856 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2018

  1. Try to trigger the Travis CI build.

    @Metatronwings
    Metatronwings committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    51ee2aa View commit details
    Browse the repository at this point in the history

  2. Try to trigger the Travis CI build.

    @Metatronwings
    Metatronwings committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f6690a2 View commit details
    Browse the repository at this point in the history

  3. Migrate from JUnit 4 to JUnit 5

    @HITTOM
    HITTOM committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    69a2262 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-for-issue-3959' of https://github.com/Metatronwings… 

    …/jabref into fix-for-issue-3959
    @HITTOM
    HITTOM committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fecd37c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2018

  1. Try to migrate from JUnit 4 to JUnit 5 

        *BibTeXMLExporterTestFiles.java
        *Test, not finished
    @Metatronwings
    Metatronwings committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    c12ccb8 View commit details
    Browse the repository at this point in the history

  2. Roll back to earlier version. 

        *BibTeXMLExporterTestFiles.java
    *CleanupWorkerTest.java
    @Metatronwings
    Metatronwings committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    ef0a13e View commit details
    Browse the repository at this point in the history

  3. Migrate from JUnit 4 to JUnit 5 

        *ImportFormatReaderIntegrationTest.java
    @Metatronwings
    Metatronwings committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    ce4a8d5 View commit details
    Browse the repository at this point in the history

  4. Migrate from JUnit 4 to JUnit 5 

        *MimeTypeDetectorTest.java
    @Metatronwings
    Metatronwings committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    095822c View commit details
    Browse the repository at this point in the history

  5. failed to modify CleanupWorkerTest

    @HITTOM
    HITTOM committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    251a2ed View commit details
    Browse the repository at this point in the history

  6. failed to modify cleanupworkTest

    @HITTOM
    HITTOM committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    08b8d3c View commit details
    Browse the repository at this point in the history

  7. failed to modify cleanupWorkTest

    @HITTOM
    HITTOM committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    47fe3e5 View commit details
    Browse the repository at this point in the history

  8. change cleanupWorkerTest to initial

    @HITTOM
    HITTOM committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    a4826df View commit details
    Browse the repository at this point in the history

  9. ***DatabaseTest*** 

    Migrate from JUnit 4 to JUnit 5
    *DBMSProcessorTest.java
        *Wait for the Travis CI
    @Metatronwings
    Metatronwings committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    ea278c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2018

  1. ***DatabaseTest*** 

    Migrate from JUnit 4 to JUnit 5
    *DBMSProcessorTest.java
        *Wait for the Travis CI
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    747d0ae View commit details
    Browse the repository at this point in the history

  2. Migrate from JUnit 4 to JUnit 5 

        *BibTeXMLExporterTestFiles.java
    *MSBibExportFormatTestFiles.java
    *All the GUI tests
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    6ca6edb View commit details
    Browse the repository at this point in the history

  3. Migrate from JUnit 4 to JUnit 5 

        *CleanupWorkerTest.java

    *It seems that worker doesn't work in cleanupRenamePdfRenamesRelativeFile() and cleanupRelativePathsConvertAbsoluteToRelativePath()
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    3cf018c View commit details
    Browse the repository at this point in the history

  4. Try to sync.

    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    1ee024c View commit details
    Browse the repository at this point in the history

  5. Migrate JUnit 4 to JUnit 5. 

        *AuthorListParameterTest.java
        -Follow up tp the newest.
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    82b3083 View commit details
    Browse the repository at this point in the history

  6. Migrate JUnit 4 to JUnit 5. 

        *CleanupWorkerTest.java
        -Delete my sout.
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    fd0cc63 View commit details
    Browse the repository at this point in the history

  7. Migrate JUnit 4 to JUnit 5. 

        *EntryTypesTest.java
        -Just some method name changes.
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    622ef47 View commit details
    Browse the repository at this point in the history

  8. Fix part of CleanupWorkerTest. 

        -cleanupRelativePathsConvertAbsoluteToRelativePath() test passed.
    -The cleanupRenamePdfRenamesRelativeFile() test still failed.
    @Metatronwings
    Metatronwings committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    3efc54b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. Migrate and sync. 

        *CiteKeyBasedFileFinderTest.java
    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    a4df9c8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master'

    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    13dcb27 View commit details
    Browse the repository at this point in the history

  3. Migrate. 

        *FileUtilTest.java
Partly migrate.
    *ModsExportFormatTestFiles.java
    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    596eabd View commit details
    Browse the repository at this point in the history

  4. Fix CleanupWorkerTest.java

    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    5ad934c View commit details
    Browse the repository at this point in the history

  5. Fix .travis.yml

    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    a917610 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary @rule. 

        *IntegrityCheckTest.java
    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    b588c53 View commit details
    Browse the repository at this point in the history

  7. AuxParserTest.java

    @W924
    W924 committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    1c5ab14 View commit details
    Browse the repository at this point in the history

  8. BibtexParserTest.java

    @W924
    W924 committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    747fb20 View commit details
    Browse the repository at this point in the history

  9. EntryComparatorTest.java

    @W924
    W924 committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    9da75f3 View commit details
    Browse the repository at this point in the history

  10. Migrate JUnit 4 to JUnit 5 -------by 1160300229

    @W924
    W924 committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    aad0e4b View commit details
    Browse the repository at this point in the history

  11. Migrate. Some tasks by my team members. 

        *LinkedFileViewModelTest.java
    *RecursiveTreeItemTest.java
    *UndoTest.java
    *EntryComparatorTest.java
    *MakeLabelWithDatabaseTest.java
    *MakeLabelWithoutDatabaseTest.java
    *CleanupUrlFormatterTest.java
    *BibtexParserTest.java
    *MedlinePlainImporterTest.java
    *SilverPlatterImporterTest.java
    *EntryLinkCheckerTest.java
    *LocalizationKeyTest.java
    *JabRefPreferencesTest.java
    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    e55d185 View commit details
    Browse the repository at this point in the history

  12. Fix 1160300302's error.

    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    6ea8b1c View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary "public". 

        *AuxParserTest.java
    @Metatronwings
    Metatronwings committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    6e7c5e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. fix architecture test by removing check for public make some classes … 

    …default visibility level
    @Siedlerchr @Metatronwings
    Siedlerchr authored and Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    ddf52d3 View commit details
    Browse the repository at this point in the history

  2. Fix "cannot find files" problem in JUnit 4.

    @Metatronwings
    Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    faefa6c View commit details
    Browse the repository at this point in the history

  3. Migrate to JUnit 5. 

        *BibTeXMLExporterTestFiles.java
    *ModsExportFormatTestFiles.java
    *MSBibExportFormatTestFiles.java
    @Metatronwings
    Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    67afcbe View commit details
    Browse the repository at this point in the history

  4. Change the slash direction. 

        *BibTeXMLExporterTestFiles.java
    *ModsExportFormatTestFiles.java
    *MSBibExportFormatTestFiles.java
    @Metatronwings
    Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    4fb0ef0 View commit details
    Browse the repository at this point in the history

  5. fix resolving of paths in msbibexporterpath update junit and correct … 

    …resource dirs in gradle
    @Siedlerchr @Metatronwings
    Siedlerchr authored and Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    fb925e5 View commit details
    Browse the repository at this point in the history

  6. Fix the path issue in 

        *BibTeXMLExporterTestFiles.java
    *ModsExportFormatTestFiles.java
    @Metatronwings
    Metatronwings committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    f46980d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Disable the failing exporter tests and change the build.gradle

    @Metatronwings
    Metatronwings committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    5e4324f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master'

    @Metatronwings
    Metatronwings committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    3daf305 View commit details
    Browse the repository at this point in the history

  3. Fix the parent folder issue by make every path to their child once. 

        -You can see in the code. :)
    @Metatronwings
    Metatronwings committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    25030de View commit details
    Browse the repository at this point in the history

  4. Fix some minor issues. 

        -Use the NIO methods in MoveFilesCleanupTest.java

    -Use toAbsolutePath() method in RenamePdfCleanupTest.java

    -Rename "tempFilename" to "tempFilePath" in BibTeXMLExporterTestFiles.java
    @Metatronwings
    Metatronwings committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    a81767a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. include main/java in resources as well convert legalcy file methods t… 

    …o nio
    @Siedlerchr @Metatronwings
    Siedlerchr authored and Metatronwings committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    3deb4f8 View commit details
    Browse the repository at this point in the history