convert bibtexkeypatterndlg to javafx as well #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
I decided to quickly convert the Bibtex Key Pattern Dialog as well to javafx., it is using the same panel from the pref tabs |
|
Sorry for not thinking so much. :( @Siedlerchr |
|
@Super-Tang No problem! Now you know it for the future and I bet you won't come in such a situation again ;) |
|
I implemented a similar fix in #4280, which goes even a step further and completely removes the textbox array. Sorry for not being quicker with my PR and the double effort. So that we don't run in a merge hell, I would propose you remove your changes to this key pattern pane class. The code looks good otherwise. |
tobiasdiez
requested changes
Aug 21, 2018
| BibtexKeyPatternDialog bibtexKeyPatternDialog = new BibtexKeyPatternDialog(frame.getCurrentBasePanel()); | ||
| bibtexKeyPatternDialog.setLocationRelativeTo(null); | ||
| bibtexKeyPatternDialog.setVisible(true); | ||
| BibtexKeyPatternDialog dlg = new BibtexKeyPatternDialog(frame.getCurrentBasePanel()); |
| if (button == ButtonType.APPLY) { | ||
| metaData.setCiteKeyPattern(bibtexKeyPatternPanel.getKeyPatternAsDatabaseBibtexKeyPattern()); | ||
| panel.markNonUndoableBaseChanged(); | ||
| } else { |
There was a problem hiding this comment.
else branch is not really needed
| @@ -20,7 +20,7 @@ protected BaseDialog() { | |||
| }); | |||
|
|
|||
| setDialogIcon(IconTheme.getJabRefImageFX()); | |||
|
|
|||
| setResizable(true); | |||
There was a problem hiding this comment.
It's a good idea to set this globally. Can you please remove the other explicit setResizable calls that are now no longer needed.
There was a problem hiding this comment.
I removed it everywhere except in the prefs dialog to not create a conflict with your other PR
base dialog is now by default resizable
Siedlerchr
force-pushed
the
fixbibtexkeypatternprefs
branch
from
d4c58e4 to
8a1d935
Compare
Siedlerchr
changed the title
Siedlerchr
added a commit
that referenced
this pull request
Aug 24, 2018
* upstream/master: (129 commits) Fix Export to clipbaord action (#4286) Add minimal height for entry editor (#4283) Fix exceptions when trying to change settings (#4284) Added a comment for the purpose of the class (#4282) Fix NPE when importing from CLI (#4281) Fix display of key patterns convert bibtexkeypatterndlg to javafx as well (#4277) Style preference sections using css Fix a few style issues Changed the behavior of the field formatting dialog (#4275) Fix checkbox display Remove small font size Style side pane in preferences Wrap preference tabs in scrollpane Fix NPE with bibdatabasecontext in preview style dialog update xmlunit and log4j jul and checkstyle Update mysql driver to 8.0.12 Rework preference dialog main class Move preferences stuff to gui.preferences Implement drag and drop for maintable (#3765) ... # Conflicts: # src/main/java/org/jabref/gui/shared/ConnectToSharedDatabaseDialog.java
Siedlerchr
added a commit
that referenced
this pull request
Aug 29, 2018
* upstream/master: (468 commits) Fix error prone warnings (#4290) Fix freeze on import into current library (#4299) Upgrade gradle to 4.10 update xmlunit and postgres update xmlunit-matchers from 2.6.0 -> 2.6.1 update gradle build-scan from 1.15.2 -> 1.16 checkstyle execute changes only if disk db present Fix Export to clipbaord action (#4286) fix npe in Merge entries dialog Add minimal height for entry editor (#4283) Fix exceptions when trying to change settings (#4284) Added a comment for the purpose of the class (#4282) Fix NPE when importing from CLI (#4281) Fix display of key patterns convert bibtexkeypatterndlg to javafx as well (#4277) Style preference sections using css Fix a few style issues Changed the behavior of the field formatting dialog (#4275) Fix checkbox display Remove small font size ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #4253 in the Bibtex key pattern panel there was an exception thrown if you had defined custom entry types or used biblatex mode.
@Super-Tang In your PR you used a fixed size for the number of labels and buttons. However, as it is possible in JabRef to customize the entry types, e.g. add new ones, the size is no longer fixed. Therefore if the number of entry types was > 19 the array threw an exception.
I now used the size of the entry type list to setup the array size and wrapped it in a Scroll Pane
Edit// I set colspan to remaining, so it uses all space
