Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update junit to release #4320

Merged
merged 1 commit into from
Sep 6, 2018
Merged

update junit to release #4320

merged 1 commit into from
Sep 6, 2018

Conversation

Siedlerchr
Copy link
Member

add rejection rule for jfoenix 9.x (requires java 9)
merge if green

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
update junit to release
de35303 
add rejection rule for jfoenix 9.x
@Siedlerchr Siedlerchr merged commit 6c5bc56 into master Sep 6, 2018
@Siedlerchr Siedlerchr deleted the updateDepss branch September 6, 2018 14:52
Siedlerchr added a commit that referenced this pull request Sep 6, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into docbookfive
25c6afb 
* upstream/master:
  update junit to release (#4320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Siedlerchr