Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto trim url field #4355

Merged
merged 4 commits into from
Sep 19, 2018
Merged

Auto trim url field #4355

merged 4 commits into from
Sep 19, 2018

Conversation

Songyu-Wang
Copy link
Contributor

@Songyu-Wang Songyu-Wang commented Sep 19, 2018 •
edited
Loading

fixes [#4288]
Created a formatter to auto trim all kinds of whitespace defined by java

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes) No need
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The code looks good to me!

Siedlerchr
Siedlerchr approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

@Siedlerchr Siedlerchr merged commit d8f6c5c into JabRef:master Sep 19, 2018
@Songyu-Wang Songyu-Wang deleted the fix-for-issue-4288 branch September 19, 2018 15:10
Siedlerchr added a commit that referenced this pull request Oct 13, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
a18a88c 
* upstream/master:
  Update Libraries (#4366)
  ArXiv fetcher support http url (#4367)
  Fix issue 3861 : XMP Dialog, Add new Groups dialog, Append Library dialog to javafx (#4264)
  fix IndexOutOfBoundsException when saving preferences
  group RadioButtons in ExportSortingPrefsTab to prevent the selection of multiple or no order types
  Convert Part of the Issue#3861 Quality->Cleanup entries (#4268)
  UPDATE gradle to 4.10.2 (#4358)
  Completed General Fields Customizer conversion to JavaFX (#4346)
  Fix JavaFX thread exception when fetching new infos (#4354)
  Auto trim url field (#4355)
  Fix freezes in entry editor (#4351)

# Conflicts:
#	src/main/java/org/jabref/preferences/PreferencesService.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Songyu-Wang @Siedlerchr @tobiasdiez