Change latex command handling only for XML Chars #4379
Conversation
|
@bernhard-kleine: I exported your provided bib entry via docbooks exporter into XML. Please check the result and let us know, if there is something missing. testBracesResult.xml.txt I will write tests based on your files, if the export is now correct. |
|
Thank you @johannes-manner, this looks good to me. For the testcase, maybe we could skip those entries where there are no latex braces in the title. |
|
This is a separate item from the docbook5 export #4319 where I am waiting for feedback. |
|
Added two test cases for (1) removed words based on an error during the latex command processing and for (2) unicode problems based on the same error. |
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { |
There was a problem hiding this comment.
Is the tearDown method really necessary?
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| Map<String, TemplateExporter> customFormats = new HashMap<>(); |
There was a problem hiding this comment.
how about inlining customFormats?
| exportFormat = exporterFactory.getExporterByName("docbook").get(); | ||
|
|
||
| databaseContext = new BibDatabaseContext(); | ||
| charset = StandardCharsets.UTF_8; |
There was a problem hiding this comment.
You can move databaseContext and charset initialization into the field, so the setUp method is less complex.
|
Ping. What is the status @johannes-manner? |
|
Oversee the comments and the ping. Sorry for that :) |
Refs #3838
Tried to solve this issue in PR #4108.
This approach is now more dedicated to the XML docbook export and not applied to all fields as the first PR was.
I am also not sure, if this issue is related to #3781, #3644?