Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "save" button in preference dialog not response #4406

Merged
merged 3 commits into from
Oct 25, 2018
Merged

fix "save" button in preference dialog not response #4406

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3a1531
fix "save" button in preference dialog not response or work
Oct 24, 2018
613db98
avoid repeat adding the same css
Oct 25, 2018
d875b9d
fix code style
Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/org/jabref/preferences/JabRefPreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,8 @@ private JabRefPreferences() {
+ "\\begin{comment}<BR><BR><b>Comment: </b> \\format[HTMLChars]{\\comment} \\end{comment}"
+ "</dd>__NEWLINE__<p></p></font>");

// set default theme
defaults.put(JabRefPreferences.FX_THEME, "Base.css");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the Base.css constant here but instead reuse a corresponding constant in ThemeLoader.

setLanguageDependentDefaultValues();
}

Expand Down