-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group hit counter when adding entries #4413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3537 by replacing the EventBus subscription by a JavaFX listener.
tobiasdiez
added
the
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
label
Oct 26, 2018
Lgtm |
Siedlerchr
added a commit
that referenced
this pull request
Oct 27, 2018
* upstream/master: (30 commits) Update README.md (#4419) Fix generate bibtex key overwrite warning dialog (#4418) Fix group hit counter when adding entries (#4413) Update README.md fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416) fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404) Add a few journal abbreviations (#4412) Fix display of radio buttons (#4411) Update issue templates Delete ISSUE_TEMPLATE.md Update issue templates Integrate mrdlib redesign (#4361) fix "save" button in preference dialog not response (#4406) show dialog before creating entry (#4405) Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398) Updates (#4402) Fixes for all mods exporter tests (#4396) Fix EntryType dialog not closed after generate button (#4390) Make rank image narrower (#4395) Fix showing multiple icons for one menu entry - fixes #4384 (#4392) ...
Siedlerchr
added a commit
that referenced
this pull request
Oct 29, 2018
* upstream/master: (54 commits) Update README.md (#4419) Fix generate bibtex key overwrite warning dialog (#4418) Fix group hit counter when adding entries (#4413) Update README.md fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416) fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404) Add a few journal abbreviations (#4412) Fix display of radio buttons (#4411) Update issue templates Delete ISSUE_TEMPLATE.md Update issue templates Integrate mrdlib redesign (#4361) fix "save" button in preference dialog not response (#4406) show dialog before creating entry (#4405) Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398) Updates (#4402) Fixes for all mods exporter tests (#4396) Fix EntryType dialog not closed after generate button (#4390) Make rank image narrower (#4395) Fix showing multiple icons for one menu entry - fixes #4384 (#4392) ...
Siedlerchr
added a commit
that referenced
this pull request
Dec 11, 2019
49a1841 Update queen-margaret-university-harvard.csl (#4443) f841560 Create uni-bern-institut-fur-musikwissenschaft-note.csl (#4401) 6ee503c Create harvard-cite-them-right-all-authors.csl (#4416) 3eceec4 Create harvard-queen-margaret-university.csl (#4441) 3c2299d JEMS.csl (#4436) bb2f60f Create open-window.csl (#4430) a908ab4 Nutrition Research Reviews (#4434) 208b693 Bump nokogiri from 1.10.3 to 1.10.4 (#4439) 122a3bb Create nmfs-west-coast-region-national-environmental-policy-act.csl (#4426) 3565fc2 Update tissue-engineering.csl (#4435) 981044e Create transposition.csl (#4375) 73ef6f3 Update tissue-engineering.csl (#4431) 7c4a4cf Update r-and-d-management.csl (#4432) 8628afb Create china-national-standard-gb-t-7714-2015-numeric.csl (#4065) 6ce148c removed spaces in harvard-gesellschaft-fur-bildung-und-forschung-in-europa.csl (#4422) 2af1c6f Create japanese-journal-of-applied-physics.csl (#4425) fc16579 Add Presses universitaires de Strasbourg style (#4411) 01e58fb Correct spacing issues and documentation link (#4423) d97cf3f Update geistes-und-kulturwissenschaften-heilmann.csl (#4421) 017947d Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4413) bffe57e Create instituto-de-pesquisas-energeticas-e-nucleares-sp.csl (#4368) 18686d1 Update and rename zeitschrift-fuer-digitale-geisteswissenschaften.csl… (#4410) bd3a5f6 Final fix for journal article cit plus other updates - uniwersytet-im-adama-mickiewicza-w-poznaniu-wydzial-anglistyki (#4417) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 49a1841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3537 by replacing the EventBus subscription by a JavaFX listener.