Delete the Deprecated BibEntry Constructor #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusDietz
added
the
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Jan 4, 2019
* upstream/master: Bump checkstyle from 8.15 to 8.16 (#4562) Bump xmpbox from 2.0.12 to 2.0.13 (#4561) Delete the deprecated BibEntry Constructor (#4560) Refactor BibEntry deprecated method (#4554) Added extra stats to be sent with MrDLib recommendations (#4452) improve styling of preferences side menu (#4556) Cleanup interfaces (#4553)
Siedlerchr
added a commit
that referenced
this pull request
Jan 10, 2019
* upstream/master: Add uncaught exception message (#4565) Converts integrity check dialog to JavaFX (#4559) Do not extract file ending from Urls (#4547) Bump checkstyle from 8.15 to 8.16 (#4562) Bump xmpbox from 2.0.12 to 2.0.13 (#4561) Delete the deprecated BibEntry Constructor (#4560) # Conflicts: # src/main/java/org/jabref/gui/DialogService.java # src/main/java/org/jabref/gui/FXDialogService.java # src/main/java/org/jabref/gui/actions/CopyFilesAction.java # src/main/java/org/jabref/gui/util/CurrentThreadTaskExecutor.java
frasca80
pushed a commit
to frasca80/jabref
that referenced
this pull request
Jan 14, 2019
Siedlerchr
added a commit
that referenced
this pull request
Jan 20, 2019
* upstream/master: (583 commits) update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one Update journalList.txt Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546) Don't set column sort type at startup (#4577) Add uncaught exception message (#4565) Converts integrity check dialog to JavaFX (#4559) Do not extract file ending from Urls (#4547) Bump checkstyle from 8.15 to 8.16 (#4562) Bump xmpbox from 2.0.12 to 2.0.13 (#4561) Delete the deprecated BibEntry Constructor (#4560) Refactor BibEntry deprecated method (#4554) Added extra stats to be sent with MrDLib recommendations (#4452) improve styling of preferences side menu (#4556) Cleanup interfaces (#4553) Bump fontbox from 2.0.12 to 2.0.13 (#4552) Bump pdfbox from 2.0.12 to 2.0.13 (#4551) Bump wiremock from 2.19.0 to 2.20.0 (#4550) Fixes that renaming a group did not change the group name in the interface (#4549) Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540) Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/model/entry/BibtexString.java
Siedlerchr
pushed a commit
that referenced
this pull request
Jan 25, 2019
* Cleanup interfaces (#4553) * improve styling of preferences side menu (#4556) * Added extra stats to be sent with MrDLib recommendations (#4452) * Refactor BibEntry deprecated method (#4554) * Refactor BibEntry deprecated method * Fixed error * More on checkstyle fixing * Fixed checkstyle issues * Added custom entrytype for types not registered in the enumerator. * Added getTypeOrDefault method refactor code to use it and fix NPE problem * Fixing checkstyle rules * More on checkstyle * More on getType getTypeOrDefault replacement * Revert Article EntryType into Electronic * Added break line between different packages * Refactor BibtextEntryTypes.getTypeOrDefault method * Removed unused import * Removed extra new line, checkstyle error fixing * Delete the deprecated BibEntry Constructor (#4560) * Bump xmpbox from 2.0.12 to 2.0.13 (#4561) Bumps xmpbox from 2.0.12 to 2.0.13. Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump checkstyle from 8.15 to 8.16 (#4562) Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.15 to 8.16. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.15...checkstyle-8.16) Signed-off-by: dependabot[bot] <support@dependabot.com> * Do not extract file ending from Urls (#4547) * Fixes #4544 Do not extract file ending from Urls * Add tests * file type for any resource type * Keep simple file name extraction for files * checkstyle * Converts integrity check dialog to JavaFX (#4559) * Converts integrity check dialog to JavaFX Moreover: - Show entry by reference and not by id. Fixes #2181. - Fixes a few issues that occurred when opening the entry editor by code from the integrity dialog - Reuse gridpane in entry editor (should have a slightly superior performance) - Improve display of progress dialog - Invoke copy files task using central task executor * fix l10n fix aborting of copy files task and showing of integrity check dialog * fix l10n * Add uncaught exception message (#4565) * Add error message for uncaught exceptions Added a new view to the project. It's shown after the uncaught exception is logged. * Add simple text to fallback error view Added a label asking the user to look into the logfiles for more details. * Add error message to language files Added the error message to the german and english language files. * Add ErrorDialogAndWait Removed the FallbackErrorView. Added the showErrorDialogAndWait call instead. * BibTex parser triggered on focus out of the text area instead of on value change event * BibTex parser triggered on focus out of the text area instead of on value change event * Added a post-parsing validation to be sure there's no relevant unconsidered content into epilog. Added DialogService in SourceTab as current NotificationPane seems not working. * Added a post-parsing validation to be sure there's no relevant unconsidered content into epilog. Added DialogService in SourceTab as current NotificationPane seems not working. * Codacy/PR Quality Review change. * Codacy/PR Quality Review change.
github-actions bot
pushed a commit
to CaptainDaVinci/jabref
that referenced
this pull request
Feb 15, 2020
9e81857 Update marine-ornithology.csl (JabRef#4566) 938537e Update government-and-opposition.csl (JabRef#4564) 50d0635 Update annales-de-demographie-historique.csl (JabRef#4560) 42b54d9 Create marine-ornithology.csl (JabRef#4559) eff41bb Create dermatology-online.csl (JabRef#4558) 3911696 Update journal-of-forensic-sciences.csl (JabRef#4554) 059ea33 Small capitals and categories (JabRef#4556) 97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557) 57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552) f481ea3 Create ipb-ppki-3.csl (JabRef#4550) 899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553) e106215 Create annales-de-demographie-historique.csl (JabRef#4512) 4dd974e Create lauterbornia.csl (JabRef#4525) e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551) f9cfe40 Add new IOP dependents (JabRef#4549) daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544) 10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 9e81857
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2020
9e81857 Update marine-ornithology.csl (#4566) 938537e Update government-and-opposition.csl (#4564) 50d0635 Update annales-de-demographie-historique.csl (#4560) 42b54d9 Create marine-ornithology.csl (#4559) eff41bb Create dermatology-online.csl (#4558) 3911696 Update journal-of-forensic-sciences.csl (#4554) 059ea33 Small capitals and categories (#4556) 97b8c84 Create CSL Styles: estudios_hispanicos.csl (#4557) 57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (#4552) f481ea3 Create ipb-ppki-3.csl (#4550) 899d302 Update journal-of-neolithic-archaeology.csl (#4553) e106215 Create annales-de-demographie-historique.csl (#4512) 4dd974e Create lauterbornia.csl (#4525) e5277ae Update sciences-po-ecole-doctorale-note-french.csl (#4551) f9cfe40 Add new IOP dependents (#4549) daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (#4544) 10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4545) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 9e81857
github-actions bot
pushed a commit
to abepolk/jabref
that referenced
this pull request
Feb 15, 2020
9e81857 Update marine-ornithology.csl (JabRef#4566) 938537e Update government-and-opposition.csl (JabRef#4564) 50d0635 Update annales-de-demographie-historique.csl (JabRef#4560) 42b54d9 Create marine-ornithology.csl (JabRef#4559) eff41bb Create dermatology-online.csl (JabRef#4558) 3911696 Update journal-of-forensic-sciences.csl (JabRef#4554) 059ea33 Small capitals and categories (JabRef#4556) 97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557) 57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552) f481ea3 Create ipb-ppki-3.csl (JabRef#4550) 899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553) e106215 Create annales-de-demographie-historique.csl (JabRef#4512) 4dd974e Create lauterbornia.csl (JabRef#4525) e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551) f9cfe40 Add new IOP dependents (JabRef#4549) daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544) 10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545) c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532) e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 9e81857
github-actions bot
pushed a commit
to NikodemKch/jabref-1
that referenced
this pull request
Feb 15, 2020
9e81857 Update marine-ornithology.csl (JabRef#4566) 938537e Update government-and-opposition.csl (JabRef#4564) 50d0635 Update annales-de-demographie-historique.csl (JabRef#4560) 42b54d9 Create marine-ornithology.csl (JabRef#4559) eff41bb Create dermatology-online.csl (JabRef#4558) 3911696 Update journal-of-forensic-sciences.csl (JabRef#4554) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 9e81857
github-actions bot
pushed a commit
to calixtus/jabref
that referenced
this pull request
Feb 17, 2020
aa52aaa Encrypt Travis CI notification email addresses (JabRef#4570) d8f2843 Update ayer.csl (JabRef#4569) 448e67e Create ayer.csl (JabRef#4565) bf1ddae Update springer-basic-author-date.csl (JabRef#4562) db525ac Update american-journal-of-physical-anthropology.csl (JabRef#4567) 9e81857 Update marine-ornithology.csl (JabRef#4566) 938537e Update government-and-opposition.csl (JabRef#4564) 50d0635 Update annales-de-demographie-historique.csl (JabRef#4560) 42b54d9 Create marine-ornithology.csl (JabRef#4559) eff41bb Create dermatology-online.csl (JabRef#4558) 3911696 Update journal-of-forensic-sciences.csl (JabRef#4554) 059ea33 Small capitals and categories (JabRef#4556) 97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557) 57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552) f481ea3 Create ipb-ppki-3.csl (JabRef#4550) 899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553) e106215 Create annales-de-demographie-historique.csl (JabRef#4512) 4dd974e Create lauterbornia.csl (JabRef#4525) e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551) f9cfe40 Add new IOP dependents (JabRef#4549) daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544) 10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: aa52aaa
github-actions bot
pushed a commit
to systemoperator/jabref
that referenced
this pull request
Feb 26, 2020
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580) 31bacc1 JCL: Fix formatting & space before locator adfc9b0 Add The Journal of Comparative Law (JabRef#4576) 599d39c Create uni-freiburg-geschichte.csl (JabRef#4561) 3ad8d40 Add Begell House styles (JabRef#4575) 223527b Create begell-apa.csl (JabRef#4574) d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572) 5b2810c Create anatomical-sciences-education.csl (JabRef#4573) 9454897 Update ASA style b3c6efd Reorder/reindent (JabRef#4571) aa52aaa Encrypt Travis CI notification email addresses (JabRef#4570) d8f2843 Update ayer.csl (JabRef#4569) 448e67e Create ayer.csl (JabRef#4565) bf1ddae Update springer-basic-author-date.csl (JabRef#4562) db525ac Update american-journal-of-physical-anthropology.csl (JabRef#4567) 9e81857 Update marine-ornithology.csl (JabRef#4566) 938537e Update government-and-opposition.csl (JabRef#4564) 50d0635 Update annales-de-demographie-historique.csl (JabRef#4560) 42b54d9 Create marine-ornithology.csl (JabRef#4559) eff41bb Create dermatology-online.csl (JabRef#4558) 3911696 Update journal-of-forensic-sciences.csl (JabRef#4554) 059ea33 Small capitals and categories (JabRef#4556) 97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557) 57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552) f481ea3 Create ipb-ppki-3.csl (JabRef#4550) 899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553) e106215 Create annales-de-demographie-historique.csl (JabRef#4512) 4dd974e Create lauterbornia.csl (JabRef#4525) e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551) f9cfe40 Add new IOP dependents (JabRef#4549) daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544) 10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: f03dece
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the followup for #4554, which removed the usage of this constructor. This PR also deleted this code.