Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "von" part to Author's last name when exporting to MS Office 2007 #4725

Merged
merged 3 commits into from
Mar 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/msbib/MsBibAuthor.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public String getMiddleName() {
}

public String getLastName() {
return author.getLast().orElse(null);
return author.getLastOnly();
}

public String getFirstLast() {
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/org/jabref/logic/msbib/MsBibAuthorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,11 @@ public void testGetLastName() {
MsBibAuthor msBibAuthor = new MsBibAuthor(author);
assertEquals("Bach", msBibAuthor.getLastName());
}

@Test
public void testGetVonAndLastName() {
Author author = new Author("John", null, "von", "Neumann", null);
MsBibAuthor msBibAuthor = new MsBibAuthor(author);
assertEquals("von Neumann", msBibAuthor.getLastName());
}
}