-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening of entry editor #4784
Conversation
Fixes #4762. The problem was that the NotificationPane was hiding the entry editor/preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh... I also investigated the problem and came up with a similar solution, but had still some problems.
I tested your change now and there are also some issues remaining:
- after creating a new database the screen is completely empty not showing the main table
- after opening the preferences and saving, I cannot close the Entry editor anymore
... but I do not really understand why these aspects are currently failing
//Edit: I pushed my proposal to branch fix-4762 if you want to have a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Just unsure if the show and edit is not called from a background thread somewhere. Could be the case that all are converted now
@matthiasgeiger sorry for the bad timing, I hope you didn't investigated too much time into this bug. You are right, these things should be fixed as well. Since I'll have on time to have a look at these issues in the next days but the bug addressed in this PR is mayor, I'll merge now but leave #4762 open as a reminder. |
Fixes #4762. The problem was that the NotificationPane was hiding the entry editor/preview.