Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening of entry editor #4784

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fix opening of entry editor #4784

merged 1 commit into from
Mar 19, 2019

Conversation

tobiasdiez
Copy link
Member

Fixes #4762. The problem was that the NotificationPane was hiding the entry editor/preview.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Fixes #4762. The problem was that the NotificationPane was hiding the entry editor/preview.
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 19, 2019
Copy link
Member

@matthiasgeiger matthiasgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh... I also investigated the problem and came up with a similar solution, but had still some problems.

I tested your change now and there are also some issues remaining:

  1. after creating a new database the screen is completely empty not showing the main table
  2. after opening the preferences and saving, I cannot close the Entry editor anymore

... but I do not really understand why these aspects are currently failing

//Edit: I pushed my proposal to branch fix-4762 if you want to have a look

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just unsure if the show and edit is not called from a background thread somewhere. Could be the case that all are converted now

@tobiasdiez
Copy link
Member Author

@matthiasgeiger sorry for the bad timing, I hope you didn't investigated too much time into this bug. You are right, these things should be fixed as well. Since I'll have on time to have a look at these issues in the next days but the bug addressed in this PR is mayor, I'll merge now but leave #4762 open as a reminder.

@tobiasdiez tobiasdiez merged commit 90376f4 into master Mar 19, 2019
@tobiasdiez tobiasdiez deleted the fixEditor branch March 19, 2019 22:29
Siedlerchr pushed a commit that referenced this pull request Mar 25, 2019
* followup of #4784 - fixes remaining issues of #4762

* use Path instead of File

Co-authored-by: matthiasgeiger <matthias.geiger@uni-bamberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants