Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color of dialogs in dark mode #4994

Merged
merged 4 commits into from
May 24, 2019
Merged

Fix background color of dialogs in dark mode #4994

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e2ace7
Fix background color of dialogs in dark mode
davidemdot May 23, 2019
13a313a
Update CHANGELOG
davidemdot May 23, 2019
f6108e5
Add new line at end of Base.css
davidemdot May 23, 2019
65f82bd
Revert "Update CHANGELOG"
davidemdot May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We fixed an issue where a database exception related to a missing timezone was too big. [#4827](https://github.com/JabRef/jabref/issues/4827)
- We fixed an issue where the command line help text had several errors, and arguments and descriptions have been rewritten to simplify and detail them better. [#4932](https://github.com/JabRef/jabref/issues/2016)
- We fixed an issue where the same menu for changing entry type had two different sizes and weights. [#4977](https://github.com/JabRef/jabref/issues/4977)
- We fixed an issue where the background color of all dialogs in the dark theme was the same as in the light one. [#4987](https://github.com/JabRef/jabref/issues/4987)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the darkmode was not officially released as part of 4.3.1 you can omit the comment here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thank you, @matthiasgeiger. Now it should be done.



### Removed
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/jabref/gui/Base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,3 +1032,7 @@ We want to have a look that matches our icons in the tool-bar */
-fx-font-size: 1.5em;
-fx-padding: 1em 0em 1em 0em;
}

.dialog-pane {
-fx-background-color: -fx-control-inner-background;
}
5 changes: 3 additions & 2 deletions src/main/java/org/jabref/gui/help/AboutDialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
.about-heading {
-fx-font-size: 30;
-fx-text-fill: -jr-theme;
}

.about-heading:pressed {
-fx-text-fill: -fx-focus-color;
-fx-text-fill: -jr-selected;
}

.top-padding {
Expand Down Expand Up @@ -33,7 +34,7 @@
}

.info-sections {
-fx-padding: 5px;
-fx-padding: 5px;
}

.logo-pane {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/gui/preferences/PreferencesDialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
#sideMenu {
-fx-background-color: -jr-white;
-fx-background-color: -fx-control-inner-background;
-fx-border-color: -fx-outer-border;
-fx-border-width: 1;
}

#sideMenu > .virtual-flow > .clipped-container > .sheet > .list-cell {
-fx-padding: 8 8 8 8;
-fx-background: -jr-white;
-fx-background: -fx-control-inner-background;
}

.preferencePaneContainer {
Expand Down