[WIP] LaTeX Integration project

[davidemdot]

Hey! This is the pull request where I will be uploading everything related to the LaTeX Integration project, which Tobias mentioned in #5002.

For the moment, I have been coding the backend of the TEX parser and preparing tests for these classes. Before the end of this week, I will add support for nested files and cross-references and will keep improving the related documentation.

Any feedback is more than welcome! :"D

[tobiasdiez]

That looks already nice. Good job! I've added a few remarks.

In general, I would also to propose to add a parse(String) method, which you can use in the tests. For example, parse("\parencite[p.4]{RefA}") and then verify that the result is what you expect.

[tobiasdiez]

A suggestion for the UI of the search result window: I like the design of ResearchGate to show the citations

We can do something similar, just replacing the reference (Minimal two-spheres ...) with the name of the latex document, and the links ("View") with an option to jump to the citation in the latex file.

In general, tables are nice if you want to compare items while lists are preferred if the user is more interested in the details of an item. I guess for the search result window we are in the second case (although that might differ from user to user).

[tobiasdiez]

The code looks already pretty good. I added a few suggestions to make the tests a bit easier to understand.

[davidemdot]

Thanks for your feedback, @Siedlerchr and @tobiasdiez! Now all identified issues should be fixed.

• TODO: Add support for multicite commands.
• TODO: Expand integration test.

[davidemdot]

@tobiasdiez, what do you think of this GUI, according to the example that you proposed?

By the way, you all can follow the development of the user interface in other pull request (this one is becoming very big).

[tobiasdiez]

I really like the user interface! Some suggestions that you may try out:

• Move the "Jump to file" a line up, directly after the file name.
• Print the file name in normal font instead of in bold (it depends a bit on where you want to draw attention to, either to the citation text or to the file containing the citation)
• Run the latex2unicode converter on the citation text in the view model (so that commands like \textbf{blaba} are replaced by a bold blaba)

I had a second look at the code here. It looks really good now, and I've only some minor comments. I think we are very close to mark this code as production-ready!

[davidemdot]

I have renamed CrossingKeys to TexBibEntriesResolver. Do you think this is a clear method signature?
Regarding BibDatabase and cloneEntry(), they were related to an idea from the first few days, but it does not make sense anymore.

All your remarks should be solved now!

Furthermore, I have been working on the GUI too. Hope to commit the latest changes soon.

[tobiasdiez]

Thanks for the update. The code looks good to me now and from my point of view we can merge this PR onto a new branch at the JabRef repository. This allows you to open further PRs against this new branch with proper updates and build checks. Moreover, our build infrastructure kicks in and we get a proper build which we could share with users to get early feedback.

@Siedlerchr @LinusDietz

[tobiasdiez]

@davidemdot if possible, can you please change the target branch to a new one (say JabRef/latexintegration). If not please open a new PR targeting this branch. Thanks

[davidemdot]

@tobiasdiez, I can change this PR to another branch, but I am not allowed to create a new one in this repo.

Could you open it, please? Just writing the name in the branch selector menu and...

[tobiasdiez]

Done! https://github.com/JabRef/jabref/tree/latexintegration

[tobiasdiez]

I've merged this now, so you can target your new PRs onto JabRef:latexintegration (with proper github notifications and build infrastructure)