-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert merge shared entries to javafx #5042
Conversation
Remove old dialog Use the defined dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise this looks good to me. I'm wondering however why we don't show the MergeEntries dialog directly?
message.append("\r\n"); | ||
message.append(Localization.lang("Local version: %0", String.valueOf(localBibEntry.getSharedBibEntryData().getVersion()))); | ||
message.append("\r\n"); | ||
message.append(Localization.lang("Please merge the shared entry with yours and press \"Merge entries\" to resolve this problem.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be something like "Press "Merge entries" to resolve the merge conflict." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Fixed the wording
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (#5040) 58d65fd Create cureus.csl (#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (#5041) 39a3fbb Create finance-and-society.csl (#5043) cf39e19 Create canadian-biosystems-engineering-journal (#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (#5024) 776002d create new independent style for deutsches-arzteblatt.csl (#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (#5036) 13e0a0b Update iso690-full-note-cs.csl (#5033) 3af2034 Create acta-medica-peruana.csl (#5037) dcbe494 Create historia-scribere.csl (#5038) 2174323 make addiction-biology.csl an AMA dependent (#5028) b01aea8 Update ios-press-books.csl (#5030) ae6d0e2 add doi for article-journal for ASA.csl (#5031) d537025 Create organised-sound.csl (#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (#5026) 3dc5157 Update amerindia.csl (#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b
Last "big" dialog for conversion to javafx
Refs #4894
Remove old dialog
Use the already created merge dialog
Now it looks like this:
Before:
One odd thing I noticed and this refs probably #4461 is that whenever I paste an entry in the shared database it gets duplicated multiple time.
This looks oddly familiar. I remember that this was having to do with the subscribers and the event bus system.