-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LaTeX citations tab to the entry editor #5137
Add LaTeX citations tab to the entry editor #5137
Conversation
src/main/java/org/jabref/gui/entryeditor/LatexReferencesTab.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/entryeditor/LatexReferencesTabViewModel.java
Outdated
Show resolved
Hide resolved
…a search is cancelled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good wise lgtm so far for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The quality of the code is really improving from time to time!
I've a few comments, but nothing serious.
src/main/java/org/jabref/gui/entryeditor/LatexCitationsTab.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/entryeditor/LatexCitationsTab.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java
Show resolved
Hide resolved
I think the cleanest solution would be to introduce a jabref/src/main/java/org/jabref/gui/texparser/ParseTexResultView.java Lines 43 to 46 in 34713f5
But the current solution is also ok (although the separation between UI-Controls and UI-Logic is not that clear). |
At first, I started doing it in that way, but it did not work properly. Because the current version has been more tested and looks stable, I thought it would be a good idea to merge this feature as soon as possible for starting to get feedback from users, and then change this point (and others) with an early patch. |
…rter # By David Méndez (47) and others # Via GitHub (5) and David Méndez (3) * upstream/master: (57 commits) fix wrong package (#5181) Remove logging message for non-existing nested files Bump applicationinsights-core from 2.4.0 to 2.4.1 (#5171) Bump archunit-junit5-engine from 0.10.2 to 0.11.0 (#5157) Bump applicationinsights-logging-log4j2 from 2.4.0 to 2.4.1 (#5172) Bump tika-core from 1.21 to 1.22 (#5166) Fix fail on testPerformExportForSingleEntry from DocBook5ExporterTest (#5168) Add a check for nested files and improve the code to skip lines (DefaultTexParser) Add latest changes to latexintegration (#5170) LaTeX integration latest changes (#5167) Move to extended enums for fields and entry types (#5148) Bump archunit-junit5-api from 0.10.2 to 0.11.0 (#5158) Revert temporal change Fix all issues from reviews of #5137 Bump com.simonharrer.modernizer from 1.6.0-1 to 1.8.0-1 (#5154) Bump checkstyle from 8.22 to 8.23 (#5153) Add a new JabRefIcons.LATEX_CITATIONS Change toString() methods Update DefaultTexParser for explaining when and why it skips the citation matching Update TexParserResult for avoiding 'orElse(null)' ... # Conflicts: # src/main/java/org/jabref/logic/importer/fileformat/PdfContentImporter.java # src/test/java/org/jabref/logic/importer/fileformat/PdfContentImporterTest.java
a20406d Added name of the editors of a given edition (#5140) 9881fc5 Ping on push, not PR, document role of dist-updater (#5137) 04668cc Create nouvelles-perspectives-en-sciences-sociales.csl (#5063) 1d94e21 Update bursa-uludag-universitesi-saglik-bilimleri-enstitusu.csl (#5047) 84f3893 Add Harvard style for Metropolia University of Applied Sciences (#5086) 8e43e79 Create opto-electronic-advances.csl (#5135) 36e4fba Update society-for-american-archaeology.csl (#5124) 69ca360 St. Paul Canon Law new style (#5138) b490ab0 Update and rename st-paul-university-faculty-of-canon-law.csl to saint-paul-university-faculty-of-canon-law.csl b498116 There is no en-CA locale 3c35f28 Metadata 7059cca Create tu-dortmund-agvm.csl (#5088) c321c98 Create new Citation type (#5093) a7edc8d Update international-organization.csl (#5103) 3d1a052 The AWS load balancer is messing things up (#5133) ca3839b Fix sort by a single macro (#5136) 5d1a7e8 Update chungara-revista-de-antropologia-chilena.csl (#5123) cd75d5d ping distribution-updater (#5132) dcf473a Update wirtschaftsuniversitat-wien-health-care-management.csl (#5125) a87085e Fix Harvard Praxisforschung Editors (#5130) d4176ca Switch automated tests to Github Actions (#5111) 726d0d8 Radiology, MPP, CORR -- small fixes: https://forums.zotero.org/discussion/85883/doi-radiology#latest https://forums.zotero.org/discussion/51058/style-request-molecular-plant-pathology#latest https://forums.zotero.org/discussion/85678/citing-style-clinical-orthopaedics-and-related-research#latest e23db68 Update to la-trobe-university-harvard style (#5119) c54b278 Create wirtschaftsuniversitat-wien-health-care-management.csl (#5110) 62fb019 Create austral-entomology.csl (#5118) afa328c Update iso690-author-date-en.csl (#5113) 5468dce Update iso690-author-date-fr-no-abstract.csl (#5112) 98af86c Update iso690-numeric-fr.csl (#5115) 09f84c4 Update iso690-author-date-fr.csl (#5114) 178a9e4 Fix current biology to superscript 1fa5ce7 Create droit-belge-centre-de-droit-prive-ulb.csl (#5107) 3a6a4bc Fix file modes (#5106) 48f50e5 Create chungara-revista-de-antropologia-chilena.csl (#5096) 1e848f8 Create the-journal-of-the-indian-law-institute.csl (#5100) 856524c Create molecular-biology.csl (#5101) eeebbf4 Create harvard-harper-adams-university.csl (#5104) d90993d Fix tests d4037bf WIP: St Paul Canon Law style git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a20406d
Here is an update for the LaTeX integration project. It adds a new tab to the entry editor (can be disabled in preferences), and also update
EntryEditor.java
to start using PreferencesService.TODO: