Fix issue 5152, tooltip and icon added to group cell #5191
Conversation
| @@ -77,6 +77,8 @@ public MainTableColumnFactory(BibDatabaseContext database, ColumnPreferences pre | |||
| } | |||
|
|
|||
| public List<TableColumn<BibEntryTableViewModel, ?>> createColumns() { | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
checkstyle is failing because of one empty line after another
| column.getStyleClass().add(GROUP_COLUMN); | ||
| setExactWidth(column, 20); | ||
| Node headerGraphic = IconTheme.JabRefIcons.DEFAULT_GROUP_ICON.getGraphicNode(); | ||
| Tooltip.install(headerGraphic, new Tooltip(Localization.lang("Group color"))); |
There was a problem hiding this comment.
you need to put the key "Group color" into the english language resource file
There was a problem hiding this comment.
Cheers for your feedback. I just wonder why codecov/project test failed on the second attempt.
There was a problem hiding this comment.
Codecov is also a mystery to me. It somehow displays the test coverage of the code, but I have no clue how it calculates. I had an PR where i just changed one line and the coverage changed for about 0.07% from fail to pass. But I think it can be ignored for the most gui-stuff. At least the core developers did not bring it up yet. 😁
|
Hi, I just saw your PR with a very close relationship to mine #5190 . There are two little issues I spotted, but I think both should work well together. 👍 |
…-added key "Group color" into english language properties
|
You can ignore codecov. It's for gui stuff not really relevant. We try to focus on important tests for logic and model, e.g. the methods and classes there should have tests. |
Siedlerchr
added
the
status: ready-for-review
|
Thanks for your contribution! |
* upstream/master: Bugfix/5045 : Modified the existing logic to comply crossref resolution with biblatex specification (JabRef#5086) Fix issue with missing year value in year column (JabRef#5197) Bump com.gradle.build-scan from 2.4 to 2.4.1 (JabRef#5199) Add citation commands to TexParser: autocite, blockcquote, and textcquote (JabRef#5195) Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm (JabRef#5141) Fix Permissions of LaTeXintegration (JabRef#5134) Border for group color indicator and some space for tooltip (JabRef#5190) Fix issue 5152, tooltip and icon added to group cell (JabRef#5191) Fix tooltips in CitationsDisplay (JabRef#5188)
Fixes #5152
Fix issue with a missing tooltip and icon in the color group column. I used DEFAULT_GROUP_ICON from JabRefICons to supplement the missing icon.