Bump error_prone_core from 2.3.2 to 2.3.3

[dependabot-preview]

Bumps error_prone_core from 2.3.2 to 2.3.3.

Release notes

Sourced from error_prone_core's releases.

Error Prone 2.3.3

New checks:

• AssignmentToMock: Fields annotated with @​Mock should not be manually assigned to.
• AutoValueImmutableFields: AutoValue recommends using immutable collections
• CompareToZero: The result of #compareTo or #compare should only be compared to 0. It is an implementation detail whether a given type returns strictly the values {-1, 0, +1} or others.
• DeduplicateConstants: This expression was previously declared as a constant; consider replacing this occurrence.
• DiscardedPostfixExpression: The result of this unary operation on a lambda parameter is discarded
• DuplicateMapKeys: Map#ofEntries will throw an IllegalArgumentException if there are any duplicate keys
• EscapedEntity: HTML entities in @code/@​literal tags will appear literally in the rendered javadoc.
• InheritDoc: Invalid use of @​inheritDoc.
• InterfaceWithOnlyStatics: This interface only contains static fields and methods; consider making it a final class instead to prevent subclassing.
• InvalidBlockTag: This tag is invalid.
• InvalidInlineTag: This tag is invalid.
• MissingSummary: A summary line is required on public/protected Javadocs.
• MixedDescriptors: The field number passed into #getFieldByNumber belongs to a different proto to the Descriptor.
• MixedMutabilityReturnType: This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.
• MockitoInternalUsage: org.mockito.internal.* is a private API and should not be used by clients
• OptionalMapToOptional: Mapping to another Optional will yield a nested Optional. Did you mean flatMap?
• OutlineNone: Setting CSS outline style to none or 0 (while not otherwise providing visual focus indicators) is inaccessible for users navigating a web page without a mouse.
• PreconditionsCheckNotNullRepeated: Including the first argument of checkNotNull in the failure message is not useful, as it will always be null.
• RedundantOverride: This override is redundant, and can be removed.
• RefersToDaggerCodegen: Don't refer to Dagger's internal or generated code
• RxReturnValueIgnored: Returned Rx objects must be checked. Ignoring a returned Rx value means it is never scheduled for execution
• TreeToString: Tree#toString shouldn't be used for Trees deriving from the code being compiled, as it discards whitespace and comments.
• TypeEquals: com.sun.tools.javac.code.Type doesn't override Object.equals and instances are not interned by javac, so testing types for equality should be done with Types#isSameType instead
• UnescapedEntity: Javadoc is interpreted as HTML, so HTML entities such as &, <, > must be escaped.
• UnusedMethod: Unused.
• UnusedNestedClass: This nested class is unused, and can be removed.
• UnusedVariable: Unused.

New date and time related checks:

• JavaDurationGetSecondsGetNano: duration.getNano() only accesses the underlying nanosecond adjustment from the whole second.
• JavaDurationWithNanos: Use of java.time.Duration.withNanos(int) is not allowed.
• JavaDurationWithSeconds: Use of java.time.Duration.withSeconds(long) is not allowed.
• JavaInstantGetSecondsGetNano: instant.getNano() only accesses the underlying nanosecond adjustment from the whole second.
• JavaTimeDefaultTimeZone: java.time APIs that silently use the default system time-zone are not allowed.
• JodaDurationConstructor: Use of new Duration(long) is not allowed. Please use Duration.millis(long) instead.
• JodaDurationWithMillis: Use of duration.withMillis(long) is not allowed. Please use Duration.millis(long) instead.
• JodaInstantWithMillis: Use of instant.withMillis(long) is not allowed. Please use new Instant(long) instead.
• JodaNewPeriod: This may have surprising semantics, e.g. new Period(LocalDate.parse("1970-01-01"), LocalDate.parse("1970-02-02")).getDays() == 1, not 32.
• JodaPlusMinusLong: Use of JodaTime's type.plus(long) or type.minus(long) is not allowed (where = {Duration,Instant,DateTime,DateMidnight}). Please use type.plus(Duration.millis(long)) or type.minus(Duration.millis(long)) instead.
• JodaTimeConverterManager: Joda-Time's ConverterManager makes the semantics of DateTime/Instant/etc construction subject to global static state. If you need to define your own converters, use a helper.
• JodaToSelf: Use of Joda-Time's DateTime.toDateTime(), Duration.toDuration(), Instant.toInstant(), Interval.toInterval(), and Period.toPeriod() are not allowed.
• JodaWithDurationAddedLong: Use of JodaTime's type.withDurationAdded(long, int) (where = {Duration,Instant,DateTime}). Please use type.withDurationAdded(Duration.millis(long), int) instead.
• TemporalAccessorGetChronoField: TemporalAccessor.get() only works for certain values of ChronoField.
• TimeUnitConversionChecker: This TimeUnit conversion looks buggy: converting from a smaller unit to a larger unit (and passing a constant), converting to/from the same TimeUnit, or converting TimeUnits where the result is statically known to be 0 or 1 are all buggy patterns.
• DurationFrom: Duration.from(Duration) returns itself; from(Period) throws a runtime exception.
• DurationGetTemporalUnit: Duration.get() only works with SECONDS or NANOS.

... (truncated)

Commits

• 24f4d7d [maven-release-plugin] prepare release v2.3.3
• 60e2caf Undo accidental version downgrade in cbe145af6e705512e6ac765e48860844ef8c00dd.
• c1f7363 Fix some NPEs in preparation for the next release
• 1f2fed9 Remove @​BugPattern.category
• 530c14e Open-source tests for annotated APIs in ApiDiffChecker.
• a115dc3 Make UnusedVariable catch (some) unused assignments, e.g.:
• 01d4242 minor additions to java.io
• 42911a2 Remove uses of @​BugPattern.category
• 5b5684f Handle static methods in InfiniteRecursion
• cbe145a Remove a spurious ".".
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

• Update frequency (including time of day and day of week)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

[Siedlerchr]

refs google/error-prone#1305

[tobiasdiez]

@dependabot ignore this minor version

Blocked by google/error-prone#1240 and tracked in #5226

[dependabot-preview]

OK, I won't notify you about version 2.3.x again, unless you re-open this PR or update to a 2.3.x release yourself.