Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated CrossRef Rest API Parameter #5495

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

CaptainDaVinci
Copy link
Contributor

@CaptainDaVinci CaptainDaVinci commented Oct 21, 2019

Fixes #5485
Changed the query parameter query.title (which is deprecated) to
query.bibliographic.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Changed the query parameter `query.title` (which is deprecated) to
`query.bibliographic`.
@Siedlerchr Siedlerchr changed the title Fixes #5485 Fix deprecated CrossRef Rest API Parameter Oct 21, 2019
@Siedlerchr Siedlerchr merged commit ba8ce99 into JabRef:master Oct 21, 2019
@Siedlerchr
Copy link
Member

Thanks for the quick fix!. For your next Pull Request please use a short description of the fix in the title and the actual (Fixes #xxx) in the description, because this makes it easier for us to see what the PR is about without checking the issue number first.

Tip: Github takes the first line of the commit message as title in a PR.
Text after an empty line (linebreak) will be considered as description text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossref API parameter query.title deprecated
2 participants