Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python raw string to preserve all special characters #5589

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Use python raw string to preserve all special characters #5589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions buildres/linux/jabrefHost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ def send_message(message):


def add_jabref_entry(data):
cmd = f'{str(JABREF_PATH)} --importBibtex """{data}"""'
"""Send string via cli as literal to preserve special characters"""
cmd = [str(JABREF_PATH), "--importBibtex", r"{}".format(data)]
logging.info(f"Try to execute command {cmd}")
try:
response = subprocess.check_output(shlex.split(cmd), stderr=subprocess.STDOUT)
response = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as exc:
logging.error(f"Failed to call JabRef: {exc.returncode} {exc.output}")
else:
Expand All @@ -78,9 +79,9 @@ def add_jabref_entry(data):
logging.info(str(message))

if "status" in message and message["status"] == "validate":
cmd = str(JABREF_PATH) + " -version"
cmd = [str(JABREF_PATH), "--version"]
try:
response = subprocess.check_output(shlex.split(cmd), stderr=subprocess.STDOUT)
response = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as exc:
logging.error(f"Failed to call JabRef: {exc.returncode} {exc.output}")
send_message({"message": "jarNotFound", "path": JABREF_PATH})
Expand Down