Write all field keys in lower case #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| class CamelCaser { |
There was a problem hiding this comment.
That class might have been useful as a future formatter, but nevermind. We can rewrite it if needed.
There was a problem hiding this comment.
I also found the class a good example for good code. However, we decided to remove unused code. 
koppor
force-pushed
the
fieldnames_lowercase
branch
from
20a2d56
to
d948c1d
Compare
|
Maybe, the UI also has to display lower case values or should it use the (currently removed) CamelCase functionality? I don't like the current |
|
In my opinion, it should use lower case, since we are standardizing on that. I'd say you are free to implement what you find more beautiful :) |
|
👍 on lower case. |
lenhard
added a commit
that referenced
this pull request
Dec 22, 2015
Write all field keys in lower case
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 14, 2024
6 tasks
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 16, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 16, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 16, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 20, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 22, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 22, 2024
MrMachiei
added a commit
to MrMachiei/jabref
that referenced
this pull request
Jan 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* BibTeX information in web search import screen. (#560) * BibTeX information in web search import screen - add toggle button (#560) * fixing style issues * fixing some repo issues (#560) * move logic to viewModel (#560) * changing headers (#560) * fix typo (#560) * further changes... (#560) * Refine text --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write all field keys in lower case. No more camel casing of field names. E.g.,
titleis written instead ofTitle,howpublishedinstead ofHowPublished, anddoiinstead ofDOI. The configuration optionUse camel case for field names (e.g., "HowPublished" instead of "howpublished")is gone.Refs #116