Fix for untranslated Strings

[CloudFenrir]

I fixed the problem with the untranslated Strings that the Issue #5701 presented, since I talk Spanish, I implemented the changes for that language.

• [x ] Manually tested changed features in running JabRef (always required)

[Siedlerchr]

Thanks you very much for your contribution! Overall your changes look good. You will just need to readd your translation using crowdin

[Siedlerchr]

Thanks for the fix, unfortunately this will be automatically overwritten by crowdin for non English translations. This means you have to re enter the translations using crowdin.

[tobiasdiez]

Is this really how it goes? I thought crowdin is intelligent enough to pick these up (at least the feature is called "sync")

[Siedlerchr]

For english this is correct, but not for other languages. Had the same problem with Italian recently. Only the english properties file is the master file. The other are translated files and therefore only synced one way from crowdin back to github.
This is also the case for new languages. you have to create new langs first in crowdin.

[Siedlerchr]

Is there any reason why you changed the formatting of the file?
if not please revert

[CloudFenrir]

So every time you add something like this : +Filter\ groups=Filter groups in the english.properties file it will automatically add it to crowdin where I'm supposed to translate it, did I understand that correctly? El mar., 10 dic. 2019 a las 1:04, Christoph (<notifications@github.com>) escribió:

…

***@***.**** commented on this pull request. ------------------------------ In src/main/resources/l10n/JabRef_en.properties <#5727 (comment)>: > @@ -361,6 +361,8 @@ File\ not\ found=File not found Filter=Filter +Filter\ groups=Filter groups For english this is correct, but not for other languages. Had the same problem with Italian recently. Only the english properties file is the master file. The other are translated files and therefore only synced one way from crowdin back to github. This is also the case for new languages. you have to create new langs first in crowdin. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5727?email_source=notifications&email_token=AKQUX5TDSRIIIONQJWQ266TQX5EQZA5CNFSM4JYUWNM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOS72SI#discussion_r355889058>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQUX5RAC2XI7ASJUXOMY6TQX5EQZANCNFSM4JYUWNMQ> .

[matthiasgeiger]

Yes, that's correct!

[CloudFenrir]

I just changed the files that were requested, I''ll commit them.

[calixtus]

Hi @CloudFenrir , unfortunatly you reverted also the very important fixes (the '%' prefix in the fxml files).

The basic workflow of the localization in JabRef is this:

1. you add a to-be-translated string either to an fxml file (by prefixing a string with a '%' character) or by using the method Localization.lang( ).
2. You add the english string to the english resource file (if not already in) just like you did earlier (like this: "Filter\ groups=Filter groups")
3. As soon as the PR is merged, the strings should be ready to translate in crowdin.
4. Every week one of the head developers is merging the localized strings from crowdin into JabRefs codebase.

[calixtus]

You can check with 'gradlew :cleanTest :test --tests "org.jabref.logic.l10n.LocalizationConsistencyTest" ' in the command line terminal, if you got every string.

[CloudFenrir]

I think I fixed it, I'll wait and be around if there's anything missing, meanwhile I'll start working on #5675 El mar., 10 dic. 2019 a las 17:50, Carl Christian Snethlage (< notifications@github.com>) escribió:

…

You can check with 'gradlew :cleanTest :test --tests "org.jabref.logic.l10n.LocalizationConsistencyTest" ' in the command line terminal, if you got every string. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5727?email_source=notifications&email_token=AKQUX5RNJFQS2YS6Y7EKNUTQYA2OLA5CNFSM4JYUWNM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGRPG4I#issuecomment-564327281>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQUX5USR2BP4HY7JPIRJMDQYA2OLANCNFSM4JYUWNMQ> .

[Siedlerchr]

Thanks! Looks good now :)
We know that the translation stuff at first is a bit confusing, we hope nontheless that you still want to contribute :)