Remove ampersand escape when writing to bib file #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use save action to handle this case. Includes also a bit of refactoring (mostly renames).
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Jan 26, 2020
# By Carl Christian Snethlage (9) and others # Via Carl Christian Snethlage (5) and GitHub (1) * upstream/master: Fixed Test Refactored constructors, PreferencesService and some minor improvements. Remove ampersand escape when writing to bib file (#5869) Fix #5862. It was indeed the throttler (at least it is working now for me) (#5868) duplicate query parameter removed (#5865) Minor refactoring, and changed comment forgotten l10n resources Minor visual adjustments Removed description, fixed ok button and added some minor improvements Moved GroupDescription-stuff to proper class Added hintTextFlow, some rewording and changed the hierarchicalContext RadioButtons to a ComboBox Converted GroupDialog to mvvm pattern # Conflicts: # src/main/resources/l10n/JabRef_en.properties
Siedlerchr
added a commit
that referenced
this pull request
Jan 30, 2020
* master: (297 commits) Replace link to Workspace set-up with new one (#5896) Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879) Switch to our IntelliJ config (#5881) Bump unirest-java from 3.4.00 to 3.4.01 (#5874) Bump junit-vintage-engine from 5.5.2 to 5.6.0 (#5875) Bump checkstyle from 8.28 to 8.29 (#5876) Bump junit-jupiter from 5.5.2 to 5.6.0 (#5877) Bump junit-platform-launcher from 1.5.2 to 1.6.0 (#5878) Change \ to / Bump byte-buddy-parent from 1.10.6 to 1.10.7 (#5873) Fix opening pdf with okular in linux (#5253) (#5855) Fixed Test Refactored constructors, PreferencesService and some minor improvements. Remove ampersand escape when writing to bib file (#5869) Fix #5862. It was indeed the throttler (at least it is working now for me) (#5868) duplicate query parameter removed (#5865) New Crowdin translations (#5864) Minor refactoring, and changed comment Bump antlr4 from 4.7.2 to 4.8-1 (#5852) Reintroducing master table index column (#5844) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use save action to handle this case. Hopefully fixes the last remaining issue in #4877.
Includes also a bit of refactoring (mostly renames).