Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE setup updated and extended #5901

Merged
merged 5 commits into from
Feb 2, 2020
Merged

Conversation

systemoperator
Copy link
Contributor

@systemoperator systemoperator commented Jan 31, 2020

Reference: #5887

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, looks good to me! 👍

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the doc and just have three little comments. The rest looks good to me.

--add-exports javafx.graphics/com.sun.javafx.css=org.controlsfx.controls
--add-exports javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix
--patch-module org.jabref=build/resources/main
* File -> Settings -> Compiler -> Annotation processors:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already missing before the other changes, but it would be nice, if you could fix it here, since it is printed there too:
... Settings -> Build, Execution, Deployment -> Compiler ...

1. Click on the settings wheel (next to the scheme chooser), then click "Import Scheme" and choose "IntelliJ Code Style.xml".
2. Select the IntelliJ configuration file `config/IntelliJ Code Style.xml`.
3. Click "OK".
4. Go to File -> Settings -> Checkstyle -> Configuration File:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here: ... Settings -> Other Settings -> Checkstyle ...

5. Activate the CheckStyle configuration file by ticking it in the list
6. Save settings by clicking "OK"
8. Open Run -> Edit Configurations...:
1. Select Application -> JabRef Main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the two lines here be merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the two lines

8. Open Run -> Edit Configurations...:
   1. Select Application -> JabRef Main

?
They could. It depends on how one likes it more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you did it in the other breadcrumbs... 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Siedlerchr Siedlerchr merged commit 55ff1c4 into JabRef:master Feb 2, 2020
Siedlerchr added a commit that referenced this pull request Feb 3, 2020
* upstream/master:
  reference to issue added (#5911)
  Fix properly resolves OrFields of required fields (#5903)
  IDE setup updated and extended (#5901)
  Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528
  Fixes problems with managing external file types (issue 5846) (#5894)
  Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e
  Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e
  Update development-strategy.md
Siedlerchr added a commit that referenced this pull request Feb 3, 2020
* master:
  reference to issue added (#5911)
  Fix properly resolves OrFields of required fields (#5903)
  IDE setup updated and extended (#5901)
  Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528
  Fixes problems with managing external file types (issue 5846) (#5894)
  Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e
  Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e
  Update development-strategy.md
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
koppor pushed a commit that referenced this pull request Feb 15, 2022
eb97405 Create frattura-ed-integrita-strutturale-fracture-and-structural-inte… (#5877)
b33ebfc make journal names title case (#5900)
1c7ecf2 Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#5901)
1a2ea12 Create trinity-college-dublin-zoology-botany-environmental-sciences-h… (#5893)
6bd742c Update harvard-anglia-ruskin-university.csl (#5840)
bc8f258 Update chicago-author-date.csl (#5836)
80aded6 Fix missing prefix for URL field (#5894)
b850a0d Update american-society-of-civil-engineers.csl (#5891)
94c1cb3 Update deutsche-gesellschaft-fur-psychologie.csl (#5861)
f66f384 Update universite-cheikh-anta-diop-faculte-de-medecine-de-pharmacie-et-dodontologie.csl (#5863)
82cf786 Update and rename acta-psychiatrica-scandinavica.csl to dependent/acta-psychiatrica-scandinavica.csl (#5879)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: eb97405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants