-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates fetching citation counts online (Google Scholar, Semantic Scholar and OpenCitations), integrates a general structure for fechting reference metadata and integrates a general websocket server for JabRef #5943
Conversation
…ed; heartbeat; subscribe/unsubscribe mechanism; refactoring; ...
Good news:
May many future features flourish well! 🎉 |
# Conflicts: # src/main/java/module-info.java
Is it possible to show a dialog at this point jabref/src/main/java/org/jabref/gui/referencemetadata/ReferenceMetadataFetcherGoogleScholar.java Line 38 in 4325489
(this is within a TaskExecutor thread, where a ProgressDialogAndWait dialog is shown in parallel) which is waiting for some user interaction? The corresponding task is created here: jabref/src/main/java/org/jabref/gui/referencemetadata/ReferenceMetadataFetcher.java Line 57 in 4325489
I found the error
But then the application does not wait on this line anymore. My intention is to integrate some simple user interaction. |
This approach looks promising: https://www.java-forum.org/thema/alert-confirmation-dialog-aus-einem-service-thread.184035/ I will try that. |
Cool, works as expected. :) |
# Conflicts: # src/main/java/module-info.java
# Conflicts: # src/main/java/org/jabref/gui/preferences/TableColumnsTabViewModel.java
# Conflicts: # src/main/java/org/jabref/model/entry/field/InternalField.java
# Conflicts: # src/main/java/module-info.java # src/main/java/org/jabref/gui/JabRefFrame.java
This is a major architectural change. With JabRef Online currently developed, this kind of architecture changes could be outdated. @systemoperator in case you have time and energy to join discussions with us on architecture, please contact us. For me it could be interesting, when thinking of integrating the MindMap feature into JabRef Desktop. See https://github.com/koppor/jabref/issues/433 for details. |
To expand on @koppor's comment: First of all, thank you very much for your contribution and I'm truly sorry that it took us so long to come to a conclusion how to proceed with this PR. That we close this PR now shouldn't be meant as a criticism of your work. In the contrary, we really like the feature to get the citations for a given entry, so feature-wise this PR goes in a very good direction. However, the implementation using the browser as a middleman is not robust enough in our opinion. Thus, we hope to implement the citation feature very soon using the new and shiny JabRef Online. https://github.com/JabRef/JabRefOnline (contributions there are warmly welcome of course) That being said, the websocket interface for JabRef is in itself a very nice addition. So if you still have the energy to go the extra mile, we would like to ask you if you could extract this part of the PR (without the citation count) to a new PR. Uses cases are to provide an alternative for the browser extension to communicate with JabRef (i.e. send references from the browser to JabRef) and for the integration with the word plugin. Thanks again! |
This PR integrates fetching citation counts online from Google Scholar, Semantic Scholar and OpenCitations, as well as a general structure for fechting reference metadata. Furthermore it integrates a general websocket server for JabRef, which currently communicates with the JabRef-Browser-Extension (JabFox) for fetching citation counts from Google Scholar.
References:
Retrieve and show (e.g. google scholar's) citation count for each table entry #5849
Integrates Google Scholar's citation count functionality, a websocket client for JabRef and other extensions/fixes JabRef-Browser-Extension#131
Change in CHANGELOG.md described (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for bigger UI changes)
Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.