Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for secrets being present at GitHub workflows #5973

Merged
merged 7 commits into from
Mar 22, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 20, 2020

When an external PR (e.g., #5967) comes in, our secrets are not known to that PR. Thus, all external PRs fail. With this PR, the workflow jobs requiring credentials are skipped.

Depends on #6145.

@koppor koppor changed the title Check for secrets being present at GitHub workflows [WIP] Check for secrets being present at GitHub workflows Feb 20, 2020
@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label Feb 20, 2020
@koppor
Copy link
Member Author

koppor commented Feb 20, 2020

Does not work that simple.

Solution proposal: https://gh.neting.ccmunity/t5/GitHub-Actions/If-expression-with-context-variable/td-p/34556

@koppor koppor force-pushed the master branch 5 times, most recently from b8ef7b7 to 21c6e5e Compare March 4, 2020 17:02
@koppor koppor force-pushed the skip-deploy-when-no-secret branch from 78d2507 to 27ba8c0 Compare March 19, 2020 21:05
@koppor koppor removed the status: depends-on-external A bug or issue that depends on an update of an external library label Mar 19, 2020
@koppor koppor force-pushed the skip-deploy-when-no-secret branch from 5cb31af to 80594a1 Compare March 20, 2020 17:18
@JabRef JabRef deleted a comment from codecov bot Mar 21, 2020
@JabRef JabRef deleted a comment from codecov bot Mar 21, 2020
@koppor koppor changed the title [WIP] Check for secrets being present at GitHub workflows Check for secrets being present at GitHub workflows Mar 21, 2020
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 21, 2020
@koppor koppor requested a review from tobiasdiez March 21, 2020 21:21
@koppor
Copy link
Member Author

koppor commented Mar 22, 2020

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that apparently there is no easier solution...

@JabRef JabRef deleted a comment from codecov bot Mar 22, 2020
@koppor koppor merged commit 0808168 into master Mar 22, 2020
@koppor koppor deleted the skip-deploy-when-no-secret branch March 22, 2020 22:47
Siedlerchr added a commit that referenced this pull request Mar 23, 2020
* upstream/master:
  Fix image path
  Check for secrets being present at GitHub workflows (#5973)
  Add "JabRef and Software Engineering"
  Make Java code acceptable for GitBook - and fix link to JUnit antipatterns
  Let "Contributing" be displayed
  Merge the reviewing steops of "Code Quality" to "Development Strategy"
  Try to include CONTRIBUTING.md in devdocs.jabref.org
  Minor improvments in CONTRIBUTING.md
  Update Codecov yaml with proper indentation (#6156)
  Complete refactor of LibraryProperties to mvvm (#6107)
  Try comment:false
  Remove duplicated line
  Fix: Only if `.sav` file has changes a recovery dialog is shown (#6116)
  Fix formatting for GitBook
  Add hint to scroll down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants