LaTeX is LaTeX - and not LaTex #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents, user-facing) Never LaTex
koppor
added
the
status: ready-for-review
calixtus
reviewed
Feb 21, 2020
| @@ -66,7 +66,7 @@ public ParseTexDialogViewModel(BibDatabaseContext databaseContext, DialogService | |||
| this.taskExecutor = taskExecutor; | |||
| this.preferencesService = preferencesService; | |||
| this.fileMonitor = fileMonitor; | |||
| this.texDirectory = new SimpleStringProperty(databaseContext.getMetaData().getLaTexFileDirectory(preferencesService.getUser()) | |||
| this.texDirectory = new SimpleStringProperty(databaseContext.getMetaData().getLatexFileDirectory(preferencesService.getUser()) | |||
There was a problem hiding this comment.
Why not also 'this.latexDirectory' and ParseLatexDialogViewModel.java?
There was a problem hiding this comment.
I will do that in a follow-up PR to keep things going.
koppor
removed
the
status: ready-for-review
stefan-kolb
approved these changes
Feb 21, 2020
|
So let's merge... ? |
|
Localization test is failing... |
|
Please no more l10n changes. We have a couple of them at 100% |
|
I kept them at 100% at #6020. Was not sooo hard to go through the languages and use Crowdin's translation memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix casing of "LaTeX" --> either "Latex" (code) or "LaTeX" (code comments, user-facing)
In the Java code, one word should start with a capital letter followed by lower capital letters. See https://google.github.io/styleguide/javaguide.html#s5.3-camel-case for details. - I fixed that, too.
Regarding the user of JabRef, I changed it to "LaTeX"