Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable/enable calculation of items in group (2) #6244

Closed
wants to merge 84 commits into from

Commits on Apr 5, 2020

  1. Adjusted GroupNodeViewModel.java.

    Now it's responsible for count if items in group (enable / disable, based on user preferences)
    Gena928 committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    72c022e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Adjusted GroupNodeViewModel.

    In case we can't use PreferencesService injection, I propose to create a property (displayItemsCount) and set this property from outside (from GroupTreeView) as True/False. True - need get count, False - NO need to get count of items.
    Also I found method "onDatabaseChanged" - it fires when you delete/add new items to group. So we need "displayItemsCount" to restrict calculation in this case also.
    
    By default displayItemsCount = False
    Gena928 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1f4e4ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebd6284 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Configuration menu
    Copy the full SHA
    c0990dc View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Configuration menu
    Copy the full SHA
    1b5d16d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6c12f4 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Configuration menu
    Copy the full SHA
    3f368e9 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Partial fix for issue 5891

    Giri authored and Giri committed May 8, 2020
    Configuration menu
    Copy the full SHA
    c8da256 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Added more tests

    Giri authored and Giri committed May 9, 2020
    Configuration menu
    Copy the full SHA
    ce33357 View commit details
    Browse the repository at this point in the history
  2. Added more tests

    Giri authored and Giri committed May 9, 2020
    Configuration menu
    Copy the full SHA
    3df1342 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Added more tests

    Giri authored and Giri committed May 12, 2020
    Configuration menu
    Copy the full SHA
    5454a09 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix-for-issue-5891' of https://github.com/silverhorse/j…

    …abref into fix-for-issue-5891
    Giri authored and Giri committed May 12, 2020
    Configuration menu
    Copy the full SHA
    e066958 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Small update to resolve GIT conflict

    My method (calculateNumberOfMatches) is no longer valid and GroupNodeViewModel must use a new methods called "findMatches"
    Gena928 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    40541ad View commit details
    Browse the repository at this point in the history
  2. Return true in action helper if file is online link

    otherwise it will be interpreted as path which obiously fails
    
    Fixes JabRef#6507
    Siedlerchr committed May 22, 2020
    Configuration menu
    Copy the full SHA
    9287490 View commit details
    Browse the repository at this point in the history
  3. fix checkstyle

    Siedlerchr committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d4f23fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1e899a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9eeb05 View commit details
    Browse the repository at this point in the history
  6. Update ActionHelper.java

    tobiasdiez authored May 22, 2020
    Configuration menu
    Copy the full SHA
    7748940 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c8344be View commit details
    Browse the repository at this point in the history
  8. Merge pull request JabRef#6511 from JabRef/fixActionHelperWithOnlineLink

    Return true in action helper if file is online link
    Siedlerchr authored May 22, 2020
    Configuration menu
    Copy the full SHA
    dffcf78 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2c1a69e View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Fix help file tests

    tobiasdiez committed May 23, 2020
    Configuration menu
    Copy the full SHA
    9882c6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e277c0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e76a92c View commit details
    Browse the repository at this point in the history
  4. Refactor externalprefs (JabRef#6509)

    * Added validators and some visual changes to ExternalTab
    
    * Added ExternalApplicationsPreferences
    
    * Refactored for reduced complexity
    
    * Refactored for eye-candy
    calixtus authored May 23, 2020
    Configuration menu
    Copy the full SHA
    03e3663 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Merge pull request JabRef#6513 from JabRef/fetcherHelp

    Fix fetcher help links
    Siedlerchr authored May 24, 2020
    Configuration menu
    Copy the full SHA
    3e96170 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    737af75 View commit details
    Browse the repository at this point in the history
  3. Merged entry table tabs

    calixtus committed May 24, 2020
    Configuration menu
    Copy the full SHA
    2a5717c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab50ca8 View commit details
    Browse the repository at this point in the history
  5. CHANGELOG.md

    calixtus committed May 24, 2020
    Configuration menu
    Copy the full SHA
    cb6804e View commit details
    Browse the repository at this point in the history
  6. Merge pull request JabRef#6514 from JabRef/extendBib

    Extend the bib file for better screenshots
    Siedlerchr authored May 24, 2020
    Configuration menu
    Copy the full SHA
    fa5f879 View commit details
    Browse the repository at this point in the history
  7. Added cache and comments

    calixtus committed May 24, 2020
    Configuration menu
    Copy the full SHA
    c8949bd View commit details
    Browse the repository at this point in the history
  8. Merge remote-tracking branch 'upstream/master' into refactor_tableprefs

    # Conflicts:
    #	src/main/java/org/jabref/preferences/JabRefPreferences.java
    #	src/main/java/org/jabref/preferences/PreferencesService.java
    calixtus committed May 24, 2020
    Configuration menu
    Copy the full SHA
    ead191e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32

    Bumps [flexmark-ext-gfm-tasklist](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 25, 2020
    Configuration menu
    Copy the full SHA
    8d468cb View commit details
    Browse the repository at this point in the history
  2. Bump flexmark from 0.61.30 to 0.61.32

    Bumps [flexmark](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 25, 2020
    Configuration menu
    Copy the full SHA
    4f75f57 View commit details
    Browse the repository at this point in the history
  3. Bump archunit-junit5-api from 0.13.1 to 0.14.1

    Bumps [archunit-junit5-api](https://github.com/TNG/ArchUnit) from 0.13.1 to 0.14.1.
    - [Release notes](https://github.com/TNG/ArchUnit/releases)
    - [Commits](TNG/ArchUnit@v0.13.1...v0.14.1)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 25, 2020
    Configuration menu
    Copy the full SHA
    196f937 View commit details
    Browse the repository at this point in the history
  4. Merge pull request JabRef#6520 from JabRef/dependabot/gradle/com.vlad…

    …sch.flexmark-flexmark-ext-gfm-tasklist-0.61.32
    
    Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    20c70a9 View commit details
    Browse the repository at this point in the history
  5. Merge pull request JabRef#6521 from JabRef/dependabot/gradle/com.vlad…

    …sch.flexmark-flexmark-0.61.32
    
    Bump flexmark from 0.61.30 to 0.61.32
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    7d3bd7b View commit details
    Browse the repository at this point in the history
  6. Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32

    Bumps [flexmark-ext-gfm-strikethrough](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 25, 2020
    Configuration menu
    Copy the full SHA
    59361fc View commit details
    Browse the repository at this point in the history
  7. Merge pull request JabRef#6522 from JabRef/dependabot/gradle/com.vlad…

    …sch.flexmark-flexmark-ext-gfm-strikethrough-0.61.32
    
    Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    43262c3 View commit details
    Browse the repository at this point in the history
  8. Merge pull request JabRef#6523 from JabRef/dependabot/gradle/com.tngt…

    …ech.archunit-archunit-junit5-api-0.14.1
    
    Bump archunit-junit5-api from 0.13.1 to 0.14.1
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    bc1e341 View commit details
    Browse the repository at this point in the history
  9. Fixed main table refresh

    calixtus committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d01f370 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b86800c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0bd2fd2 View commit details
    Browse the repository at this point in the history
  12. CHANGELOG.md

    calixtus committed May 25, 2020
    Configuration menu
    Copy the full SHA
    25bd506 View commit details
    Browse the repository at this point in the history
  13. Merge pull request JabRef#6407 from nsmt09/fix-for-issue-6297

    Fixed an issue where a new entry is not shown in the library if a filter/search is active
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    6f34de3 View commit details
    Browse the repository at this point in the history
  14. Merge pull request JabRef#6516 from leitianjian/entry-preview-content…

    …-update
    
    Add some javadoc and fix the preview update issue
    Siedlerchr authored May 25, 2020
    Configuration menu
    Copy the full SHA
    86b04a7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Configuration menu
    Copy the full SHA
    0d7156b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Configuration menu
    Copy the full SHA
    861e61e View commit details
    Browse the repository at this point in the history
  2. update changelog

    Siedlerchr committed May 27, 2020
    Configuration menu
    Copy the full SHA
    56b0cee View commit details
    Browse the repository at this point in the history
  3. checkstyle argh

    Siedlerchr committed May 27, 2020
    Configuration menu
    Copy the full SHA
    104f697 View commit details
    Browse the repository at this point in the history
  4. Merge pull request JabRef#6531 from JabRef/fixEntryTypeMissing

    Allow entrytype as sorting criterion
    Siedlerchr authored May 27, 2020
    Configuration menu
    Copy the full SHA
    bb19d29 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    47846bf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c119ca2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. updating text for checkbox

    mbadar committed May 28, 2020
    Configuration menu
    Copy the full SHA
    4b997f8 View commit details
    Browse the repository at this point in the history
  2. reverting change from other properties files

    mbadar committed May 28, 2020
    Configuration menu
    Copy the full SHA
    5668049 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of https://github.com/JabRef/jabref into fix-fo…

    …r-issue-5891
    mbadar committed May 28, 2020
    Configuration menu
    Copy the full SHA
    62a6961 View commit details
    Browse the repository at this point in the history
  4. Fixes generated bibtex key and display of institute authors (JabRef#6479

    )
    
    * Fix Pattern.compile for frequently used regexes
    
    * Fix one additional Pattern.compile
    
    * Fix style and unnecessary escape sequences
    
    * Fix invalid index in call to substring
    
    The original condition is evaluated to false.
    The substring is shorter than "uni".
    
    * Refactor name and javadoc of a regex
    
    * Fix use of compiled regex for matching department
    
    * Fix check for uppercase letter
    
    Perhaps the assumption should be that the letters are ASCII.
    If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z'
    might make more sense.
    I am not convinced about doing this with a regex.
    
    * Fix usage of uncompiled regex
    
    * Fix readability?
    
    * Add test cases
    
    Both test cases involves an author name containing department or school
     without university or institute of technology.
    
    * Fix `null` appearing as part of author name
    
    Corporate authors without university/institute of technology
    
    * Refactor name of capital regex pattern
    
    * Add debug output for reordering of names in fields
    
    * Add helper methods
    
    * Fix missing negation in "uni" matching
    
    * Fix test cases for corporate authors
    
    * Fix to keep all uppercase letters in abbreviation
    
    * Fix commented out code
    
    * Fix key for institution's name containing keyword
    
    If the name of an institution can't be split, assume that
    "School"/"Department" is part of the name.
    
    * Fix test case for short institution name
    
    * Refactor check for institution types
    
    * Refactor comments and names improving readability?
    
    * Refactor to improve readability and closure
    
    * Fix JavaDoc
    
    Minor typos and the "rest" part is now created differently.
    
    * Fix JavaDoc typos
    
    * Fix preliminary order for authors -> latexfree
    
    * Drop logger
    
    * Add convenience methods for cached latexfree names
    
    * Add name format method for names containing latex
    
    * Add call to formatNameLatexFree
    
    * Fix unclear statement in JavaDoc
    
    * Fix to only keep the first character of each word
    
    There are some examples that will turn out wrong if only capital letters
     are kept, e.g., "iOS Developer University Program".
     The original problem with "The School of Life" becoming too short is
     avoided by only removing school/department for names containing two or
      more ',' separated strings. This will still produce an unexpected
       result if the address of the institution is part of the authors field
    
    * Add latexfree Natbib test cases
    
    * Fix typo in latex-free test cases
    
    * Add Natbib test with escaped brackets
    
    * Add Natbib institution test with escaped brackets
    
    * Add test for latex-free comma separated lastnames
    
    * Add test for latex-free comma separated first name
    
    First name first and abbreviated first name first
    
    * Add test for latex-free comma separated last name
    
    Last name first and abbreviated first names
    
    * Fix adherence to JavaDoc and readability(?)
    
    * Fix readability(?)
    
    * Fix CheckStyle issues
    
    The deprecated static methods BibtexKeyGenerator.generateKey are moved
    to the test file as a similar convenience method is required for
    the test cases. Suppress warning has been added for some methods.
    
    * Fix CHANGELOG.md
    
    * Fix mistake in BibtexKeyGeneratorTest
    
    generateKey was not copy-pasted properly.
    
    * Add test for oxford comma
    
    * Fix miss-capitalization of enum
    
    * Fix fields not displayed latex-free
    
    * Fix in-line methods in MainTableNameFormatter
    
    * Fix in-line of generateKey() method
    
    * Fix separating tests into parsing/representation
    
    * Fix cache check and simplify expressions
    
    * Drop inlined methods
    
    * Fix most abbreviated abbreviations
    
    * Drop old formatName method
    
    * Refactor formatNameLatexFree
    
    The author list parsing is moved outside of the if/else statements
    
    * Refactor new parse tests
    
    * Add more parse tests
    
    * Drop all test cases containing escaped brackets
    
    * Refactor parse with latex tests
    
    Move them close to other parse tests
    
    * Fix my own spelling mistakes
    
    * Refactor abbreviation name
    k3KAW8Pnf7mkmdSMPHz27 authored May 28, 2020
    Configuration menu
    Copy the full SHA
    08eccb6 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'upstream/master' into refactor_tableprefs

    # Conflicts:
    #	src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java
    #	src/main/java/org/jabref/gui/maintable/MainTableNameFormatter.java
    calixtus committed May 28, 2020
    Configuration menu
    Copy the full SHA
    62f3038 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3135197 View commit details
    Browse the repository at this point in the history
  7. Fix links in the readme

    tobiasdiez authored May 28, 2020
    Configuration menu
    Copy the full SHA
    526ba89 View commit details
    Browse the repository at this point in the history
  8. updating text

    mbadar committed May 28, 2020
    Configuration menu
    Copy the full SHA
    0ce7c8f View commit details
    Browse the repository at this point in the history
  9. updating text

    mbadar committed May 28, 2020
    Configuration menu
    Copy the full SHA
    6a1940f View commit details
    Browse the repository at this point in the history
  10. Merge pull request JabRef#6451 from silverhorse/fix-for-issue-5891

    Removed BIB file directory from search when preferences has option unchecked
    Siedlerchr authored May 28, 2020
    Configuration menu
    Copy the full SHA
    ffa07cd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d43bcfa View commit details
    Browse the repository at this point in the history
  12. Fixed merge error

    calixtus committed May 28, 2020
    Configuration menu
    Copy the full SHA
    c1867e5 View commit details
    Browse the repository at this point in the history
  13. Merge pull request JabRef#6518 from JabRef/refactor_tableprefs

    Refactor main table preferences
    Siedlerchr authored May 28, 2020
    Configuration menu
    Copy the full SHA
    41678ce View commit details
    Browse the repository at this point in the history
  14. Bump flexmark from 0.61.32 to 0.62.0

    Bumps [flexmark](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 28, 2020
    Configuration menu
    Copy the full SHA
    ad8ac9d View commit details
    Browse the repository at this point in the history
  15. Bump flexmark-ext-gfm-tasklist from 0.61.32 to 0.62.0

    Bumps [flexmark-ext-gfm-tasklist](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 28, 2020
    Configuration menu
    Copy the full SHA
    4eb2316 View commit details
    Browse the repository at this point in the history
  16. Bump bcprov-jdk15on from 1.65 to 1.65.01

    Bumps [bcprov-jdk15on](https://github.com/bcgit/bc-java) from 1.65 to 1.65.01.
    - [Release notes](https://github.com/bcgit/bc-java/releases)
    - [Changelog](https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html)
    - [Commits](https://github.com/bcgit/bc-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored May 28, 2020
    Configuration menu
    Copy the full SHA
    cab28ab View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Merge pull request JabRef#6550 from JabRef/dependabot/gradle/org.boun…

    …cycastle-bcprov-jdk15on-1.65.01
    
    Bump bcprov-jdk15on from 1.65 to 1.65.01
    Siedlerchr authored May 29, 2020
    Configuration menu
    Copy the full SHA
    8ff20f1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request JabRef#6547 from JabRef/dependabot/gradle/com.vlad…

    …sch.flexmark-flexmark-0.62.0
    
    Bump flexmark from 0.61.32 to 0.62.0
    Siedlerchr authored May 29, 2020
    Configuration menu
    Copy the full SHA
    a852963 View commit details
    Browse the repository at this point in the history
  3. Merge pull request JabRef#6548 from JabRef/dependabot/gradle/com.vlad…

    …sch.flexmark-flexmark-ext-gfm-tasklist-0.62.0
    
    Bump flexmark-ext-gfm-tasklist from 0.61.32 to 0.62.0
    Siedlerchr authored May 29, 2020
    Configuration menu
    Copy the full SHA
    5cb139c View commit details
    Browse the repository at this point in the history
  4. Restructure first paragraph

    koppor authored May 29, 2020
    Configuration menu
    Copy the full SHA
    8b35b69 View commit details
    Browse the repository at this point in the history
  5. Fix html

    koppor authored May 29, 2020
    Configuration menu
    Copy the full SHA
    2c30f20 View commit details
    Browse the repository at this point in the history
  6. Bump flexmark-ext-gfm-strikethrough from 0.61.32 to 0.62.0 (JabRef#6546)

    Bumps [flexmark-ext-gfm-strikethrough](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0.
    - [Release notes](https://github.com/vsch/flexmark-java/releases)
    - [Commits](https://github.com/vsch/flexmark-java/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored May 29, 2020
    Configuration menu
    Copy the full SHA
    9742ee1 View commit details
    Browse the repository at this point in the history
  7. Add authors

    koppor committed May 29, 2020
    Configuration menu
    Copy the full SHA
    53e8c36 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    68f90c0 View commit details
    Browse the repository at this point in the history
  9. Adjusted GroupNodeViewModel.java.

    Now it's responsible for count if items in group (enable / disable, based on user preferences)
    Gena928 authored and calixtus committed May 29, 2020
    Configuration menu
    Copy the full SHA
    684abf6 View commit details
    Browse the repository at this point in the history
  10. Adjusted GroupNodeViewModel.

    In case we can't use PreferencesService injection, I propose to create a property (displayItemsCount) and set this property from outside (from GroupTreeView) as True/False. True - need get count, False - NO need to get count of items.
    Also I found method "onDatabaseChanged" - it fires when you delete/add new items to group. So we need "displayItemsCount" to restrict calculation in this case also.
    
    By default displayItemsCount = False
    Gena928 authored and calixtus committed May 29, 2020
    Configuration menu
    Copy the full SHA
    58e5492 View commit details
    Browse the repository at this point in the history
  11. Update GroupNodeViewModel.java

    Gena928 authored and calixtus committed May 29, 2020
    Configuration menu
    Copy the full SHA
    2155917 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    30cb675 View commit details
    Browse the repository at this point in the history
  13. Update GroupNodeViewModel.java

    tobiasdiez authored and calixtus committed May 29, 2020
    Configuration menu
    Copy the full SHA
    5c1998f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2da0d06 View commit details
    Browse the repository at this point in the history