-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable/enable calculation of items in group (2) #6244
Commits on Apr 5, 2020
-
Adjusted GroupNodeViewModel.java.
Now it's responsible for count if items in group (enable / disable, based on user preferences)
Configuration menu - View commit details
-
Copy full SHA for 72c022e - Browse repository at this point
Copy the full SHA 72c022eView commit details
Commits on Apr 6, 2020
-
In case we can't use PreferencesService injection, I propose to create a property (displayItemsCount) and set this property from outside (from GroupTreeView) as True/False. True - need get count, False - NO need to get count of items. Also I found method "onDatabaseChanged" - it fires when you delete/add new items to group. So we need "displayItemsCount" to restrict calculation in this case also. By default displayItemsCount = False
Configuration menu - View commit details
-
Copy full SHA for 1f4e4ad - Browse repository at this point
Copy the full SHA 1f4e4adView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd6284 - Browse repository at this point
Copy the full SHA ebd6284View commit details
Commits on Apr 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c0990dc - Browse repository at this point
Copy the full SHA c0990dcView commit details
Commits on Apr 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1b5d16d - Browse repository at this point
Copy the full SHA 1b5d16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c12f4 - Browse repository at this point
Copy the full SHA f6c12f4View commit details
Commits on May 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3f368e9 - Browse repository at this point
Copy the full SHA 3f368e9View commit details
Commits on May 8, 2020
-
Giri authored and Giri committed
May 8, 2020 Configuration menu - View commit details
-
Copy full SHA for c8da256 - Browse repository at this point
Copy the full SHA c8da256View commit details
Commits on May 9, 2020
-
Giri authored and Giri committed
May 9, 2020 Configuration menu - View commit details
-
Copy full SHA for ce33357 - Browse repository at this point
Copy the full SHA ce33357View commit details -
Giri authored and Giri committed
May 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 3df1342 - Browse repository at this point
Copy the full SHA 3df1342View commit details
Commits on May 12, 2020
-
Giri authored and Giri committed
May 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 5454a09 - Browse repository at this point
Copy the full SHA 5454a09View commit details -
Merge branch 'fix-for-issue-5891' of https://github.com/silverhorse/j…
…abref into fix-for-issue-5891
Giri authored and Giri committedMay 12, 2020 Configuration menu - View commit details
-
Copy full SHA for e066958 - Browse repository at this point
Copy the full SHA e066958View commit details
Commits on May 22, 2020
-
Small update to resolve GIT conflict
My method (calculateNumberOfMatches) is no longer valid and GroupNodeViewModel must use a new methods called "findMatches"
Configuration menu - View commit details
-
Copy full SHA for 40541ad - Browse repository at this point
Copy the full SHA 40541adView commit details -
Return true in action helper if file is online link
otherwise it will be interpreted as path which obiously fails Fixes JabRef#6507
Configuration menu - View commit details
-
Copy full SHA for 9287490 - Browse repository at this point
Copy the full SHA 9287490View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f23fa - Browse repository at this point
Copy the full SHA d4f23faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e899a - Browse repository at this point
Copy the full SHA b1e899aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9eeb05 - Browse repository at this point
Copy the full SHA a9eeb05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7748940 - Browse repository at this point
Copy the full SHA 7748940View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8344be - Browse repository at this point
Copy the full SHA c8344beView commit details -
Merge pull request JabRef#6511 from JabRef/fixActionHelperWithOnlineLink
Return true in action helper if file is online link
Configuration menu - View commit details
-
Copy full SHA for dffcf78 - Browse repository at this point
Copy the full SHA dffcf78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c1a69e - Browse repository at this point
Copy the full SHA 2c1a69eView commit details
Commits on May 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9882c6d - Browse repository at this point
Copy the full SHA 9882c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e277c0c - Browse repository at this point
Copy the full SHA e277c0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e76a92c - Browse repository at this point
Copy the full SHA e76a92cView commit details -
Refactor externalprefs (JabRef#6509)
* Added validators and some visual changes to ExternalTab * Added ExternalApplicationsPreferences * Refactored for reduced complexity * Refactored for eye-candy
Configuration menu - View commit details
-
Copy full SHA for 03e3663 - Browse repository at this point
Copy the full SHA 03e3663View commit details
Commits on May 24, 2020
-
Merge pull request JabRef#6513 from JabRef/fetcherHelp
Fix fetcher help links
Configuration menu - View commit details
-
Copy full SHA for 3e96170 - Browse repository at this point
Copy the full SHA 3e96170View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737af75 - Browse repository at this point
Copy the full SHA 737af75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5717c - Browse repository at this point
Copy the full SHA 2a5717cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab50ca8 - Browse repository at this point
Copy the full SHA ab50ca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6804e - Browse repository at this point
Copy the full SHA cb6804eView commit details -
Merge pull request JabRef#6514 from JabRef/extendBib
Extend the bib file for better screenshots
Configuration menu - View commit details
-
Copy full SHA for fa5f879 - Browse repository at this point
Copy the full SHA fa5f879View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8949bd - Browse repository at this point
Copy the full SHA c8949bdView commit details -
Merge remote-tracking branch 'upstream/master' into refactor_tableprefs
# Conflicts: # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/main/java/org/jabref/preferences/PreferencesService.java
Configuration menu - View commit details
-
Copy full SHA for ead191e - Browse repository at this point
Copy the full SHA ead191eView commit details
Commits on May 25, 2020
-
Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32
Bumps [flexmark-ext-gfm-tasklist](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for 8d468cb - Browse repository at this point
Copy the full SHA 8d468cbView commit details -
Bump flexmark from 0.61.30 to 0.61.32
Bumps [flexmark](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for 4f75f57 - Browse repository at this point
Copy the full SHA 4f75f57View commit details -
Bump archunit-junit5-api from 0.13.1 to 0.14.1
Bumps [archunit-junit5-api](https://github.com/TNG/ArchUnit) from 0.13.1 to 0.14.1. - [Release notes](https://github.com/TNG/ArchUnit/releases) - [Commits](TNG/ArchUnit@v0.13.1...v0.14.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for 196f937 - Browse repository at this point
Copy the full SHA 196f937View commit details -
Merge pull request JabRef#6520 from JabRef/dependabot/gradle/com.vlad…
…sch.flexmark-flexmark-ext-gfm-tasklist-0.61.32 Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32
Configuration menu - View commit details
-
Copy full SHA for 20c70a9 - Browse repository at this point
Copy the full SHA 20c70a9View commit details -
Merge pull request JabRef#6521 from JabRef/dependabot/gradle/com.vlad…
…sch.flexmark-flexmark-0.61.32 Bump flexmark from 0.61.30 to 0.61.32
Configuration menu - View commit details
-
Copy full SHA for 7d3bd7b - Browse repository at this point
Copy the full SHA 7d3bd7bView commit details -
Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32
Bumps [flexmark-ext-gfm-strikethrough](https://github.com/vsch/flexmark-java) from 0.61.30 to 0.61.32. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for 59361fc - Browse repository at this point
Copy the full SHA 59361fcView commit details -
Merge pull request JabRef#6522 from JabRef/dependabot/gradle/com.vlad…
…sch.flexmark-flexmark-ext-gfm-strikethrough-0.61.32 Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32
Configuration menu - View commit details
-
Copy full SHA for 43262c3 - Browse repository at this point
Copy the full SHA 43262c3View commit details -
Merge pull request JabRef#6523 from JabRef/dependabot/gradle/com.tngt…
…ech.archunit-archunit-junit5-api-0.14.1 Bump archunit-junit5-api from 0.13.1 to 0.14.1
Configuration menu - View commit details
-
Copy full SHA for bc1e341 - Browse repository at this point
Copy the full SHA bc1e341View commit details -
Configuration menu - View commit details
-
Copy full SHA for d01f370 - Browse repository at this point
Copy the full SHA d01f370View commit details -
Configuration menu - View commit details
-
Copy full SHA for b86800c - Browse repository at this point
Copy the full SHA b86800cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd2fd2 - Browse repository at this point
Copy the full SHA 0bd2fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25bd506 - Browse repository at this point
Copy the full SHA 25bd506View commit details -
Merge pull request JabRef#6407 from nsmt09/fix-for-issue-6297
Fixed an issue where a new entry is not shown in the library if a filter/search is active
Configuration menu - View commit details
-
Copy full SHA for 6f34de3 - Browse repository at this point
Copy the full SHA 6f34de3View commit details -
Merge pull request JabRef#6516 from leitianjian/entry-preview-content…
…-update Add some javadoc and fix the preview update issue
Configuration menu - View commit details
-
Copy full SHA for 86b04a7 - Browse repository at this point
Copy the full SHA 86b04a7View commit details
Commits on May 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0d7156b - Browse repository at this point
Copy the full SHA 0d7156bView commit details
Commits on May 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 861e61e - Browse repository at this point
Copy the full SHA 861e61eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b0cee - Browse repository at this point
Copy the full SHA 56b0ceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 104f697 - Browse repository at this point
Copy the full SHA 104f697View commit details -
Merge pull request JabRef#6531 from JabRef/fixEntryTypeMissing
Allow entrytype as sorting criterion
Configuration menu - View commit details
-
Copy full SHA for bb19d29 - Browse repository at this point
Copy the full SHA bb19d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47846bf - Browse repository at this point
Copy the full SHA 47846bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c119ca2 - Browse repository at this point
Copy the full SHA c119ca2View commit details
Commits on May 28, 2020
-
mbadar committed
May 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 4b997f8 - Browse repository at this point
Copy the full SHA 4b997f8View commit details -
reverting change from other properties files
mbadar committedMay 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 5668049 - Browse repository at this point
Copy the full SHA 5668049View commit details -
Merge branch 'master' of https://github.com/JabRef/jabref into fix-fo…
…r-issue-5891
mbadar committedMay 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 62a6961 - Browse repository at this point
Copy the full SHA 62a6961View commit details -
Fixes generated bibtex key and display of institute authors (JabRef#6479
) * Fix Pattern.compile for frequently used regexes * Fix one additional Pattern.compile * Fix style and unnecessary escape sequences * Fix invalid index in call to substring The original condition is evaluated to false. The substring is shorter than "uni". * Refactor name and javadoc of a regex * Fix use of compiled regex for matching department * Fix check for uppercase letter Perhaps the assumption should be that the letters are ASCII. If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z' might make more sense. I am not convinced about doing this with a regex. * Fix usage of uncompiled regex * Fix readability? * Add test cases Both test cases involves an author name containing department or school without university or institute of technology. * Fix `null` appearing as part of author name Corporate authors without university/institute of technology * Refactor name of capital regex pattern * Add debug output for reordering of names in fields * Add helper methods * Fix missing negation in "uni" matching * Fix test cases for corporate authors * Fix to keep all uppercase letters in abbreviation * Fix commented out code * Fix key for institution's name containing keyword If the name of an institution can't be split, assume that "School"/"Department" is part of the name. * Fix test case for short institution name * Refactor check for institution types * Refactor comments and names improving readability? * Refactor to improve readability and closure * Fix JavaDoc Minor typos and the "rest" part is now created differently. * Fix JavaDoc typos * Fix preliminary order for authors -> latexfree * Drop logger * Add convenience methods for cached latexfree names * Add name format method for names containing latex * Add call to formatNameLatexFree * Fix unclear statement in JavaDoc * Fix to only keep the first character of each word There are some examples that will turn out wrong if only capital letters are kept, e.g., "iOS Developer University Program". The original problem with "The School of Life" becoming too short is avoided by only removing school/department for names containing two or more ',' separated strings. This will still produce an unexpected result if the address of the institution is part of the authors field * Add latexfree Natbib test cases * Fix typo in latex-free test cases * Add Natbib test with escaped brackets * Add Natbib institution test with escaped brackets * Add test for latex-free comma separated lastnames * Add test for latex-free comma separated first name First name first and abbreviated first name first * Add test for latex-free comma separated last name Last name first and abbreviated first names * Fix adherence to JavaDoc and readability(?) * Fix readability(?) * Fix CheckStyle issues The deprecated static methods BibtexKeyGenerator.generateKey are moved to the test file as a similar convenience method is required for the test cases. Suppress warning has been added for some methods. * Fix CHANGELOG.md * Fix mistake in BibtexKeyGeneratorTest generateKey was not copy-pasted properly. * Add test for oxford comma * Fix miss-capitalization of enum * Fix fields not displayed latex-free * Fix in-line methods in MainTableNameFormatter * Fix in-line of generateKey() method * Fix separating tests into parsing/representation * Fix cache check and simplify expressions * Drop inlined methods * Fix most abbreviated abbreviations * Drop old formatName method * Refactor formatNameLatexFree The author list parsing is moved outside of the if/else statements * Refactor new parse tests * Add more parse tests * Drop all test cases containing escaped brackets * Refactor parse with latex tests Move them close to other parse tests * Fix my own spelling mistakes * Refactor abbreviation name
Configuration menu - View commit details
-
Copy full SHA for 08eccb6 - Browse repository at this point
Copy the full SHA 08eccb6View commit details -
Merge remote-tracking branch 'upstream/master' into refactor_tableprefs
# Conflicts: # src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java # src/main/java/org/jabref/gui/maintable/MainTableNameFormatter.java
Configuration menu - View commit details
-
Copy full SHA for 62f3038 - Browse repository at this point
Copy the full SHA 62f3038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3135197 - Browse repository at this point
Copy the full SHA 3135197View commit details -
Configuration menu - View commit details
-
Copy full SHA for 526ba89 - Browse repository at this point
Copy the full SHA 526ba89View commit details -
mbadar committed
May 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 0ce7c8f - Browse repository at this point
Copy the full SHA 0ce7c8fView commit details -
mbadar committed
May 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 6a1940f - Browse repository at this point
Copy the full SHA 6a1940fView commit details -
Merge pull request JabRef#6451 from silverhorse/fix-for-issue-5891
Removed BIB file directory from search when preferences has option unchecked
Configuration menu - View commit details
-
Copy full SHA for ffa07cd - Browse repository at this point
Copy the full SHA ffa07cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d43bcfa - Browse repository at this point
Copy the full SHA d43bcfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1867e5 - Browse repository at this point
Copy the full SHA c1867e5View commit details -
Merge pull request JabRef#6518 from JabRef/refactor_tableprefs
Refactor main table preferences
Configuration menu - View commit details
-
Copy full SHA for 41678ce - Browse repository at this point
Copy the full SHA 41678ceView commit details -
Bump flexmark from 0.61.32 to 0.62.0
Bumps [flexmark](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for ad8ac9d - Browse repository at this point
Copy the full SHA ad8ac9dView commit details -
Bump flexmark-ext-gfm-tasklist from 0.61.32 to 0.62.0
Bumps [flexmark-ext-gfm-tasklist](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for 4eb2316 - Browse repository at this point
Copy the full SHA 4eb2316View commit details -
Bump bcprov-jdk15on from 1.65 to 1.65.01
Bumps [bcprov-jdk15on](https://github.com/bcgit/bc-java) from 1.65 to 1.65.01. - [Release notes](https://github.com/bcgit/bc-java/releases) - [Changelog](https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html) - [Commits](https://github.com/bcgit/bc-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Configuration menu - View commit details
-
Copy full SHA for cab28ab - Browse repository at this point
Copy the full SHA cab28abView commit details
Commits on May 29, 2020
-
Merge pull request JabRef#6550 from JabRef/dependabot/gradle/org.boun…
…cycastle-bcprov-jdk15on-1.65.01 Bump bcprov-jdk15on from 1.65 to 1.65.01
Configuration menu - View commit details
-
Copy full SHA for 8ff20f1 - Browse repository at this point
Copy the full SHA 8ff20f1View commit details -
Merge pull request JabRef#6547 from JabRef/dependabot/gradle/com.vlad…
…sch.flexmark-flexmark-0.62.0 Bump flexmark from 0.61.32 to 0.62.0
Configuration menu - View commit details
-
Copy full SHA for a852963 - Browse repository at this point
Copy the full SHA a852963View commit details -
Merge pull request JabRef#6548 from JabRef/dependabot/gradle/com.vlad…
…sch.flexmark-flexmark-ext-gfm-tasklist-0.62.0 Bump flexmark-ext-gfm-tasklist from 0.61.32 to 0.62.0
Configuration menu - View commit details
-
Copy full SHA for 5cb139c - Browse repository at this point
Copy the full SHA 5cb139cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b35b69 - Browse repository at this point
Copy the full SHA 8b35b69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c30f20 - Browse repository at this point
Copy the full SHA 2c30f20View commit details -
Bump flexmark-ext-gfm-strikethrough from 0.61.32 to 0.62.0 (JabRef#6546)
Bumps [flexmark-ext-gfm-strikethrough](https://github.com/vsch/flexmark-java) from 0.61.32 to 0.62.0. - [Release notes](https://github.com/vsch/flexmark-java/releases) - [Commits](https://github.com/vsch/flexmark-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9742ee1 - Browse repository at this point
Copy the full SHA 9742ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e8c36 - Browse repository at this point
Copy the full SHA 53e8c36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68f90c0 - Browse repository at this point
Copy the full SHA 68f90c0View commit details -
Adjusted GroupNodeViewModel.java.
Now it's responsible for count if items in group (enable / disable, based on user preferences)
Configuration menu - View commit details
-
Copy full SHA for 684abf6 - Browse repository at this point
Copy the full SHA 684abf6View commit details -
In case we can't use PreferencesService injection, I propose to create a property (displayItemsCount) and set this property from outside (from GroupTreeView) as True/False. True - need get count, False - NO need to get count of items. Also I found method "onDatabaseChanged" - it fires when you delete/add new items to group. So we need "displayItemsCount" to restrict calculation in this case also. By default displayItemsCount = False
Configuration menu - View commit details
-
Copy full SHA for 58e5492 - Browse repository at this point
Copy the full SHA 58e5492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2155917 - Browse repository at this point
Copy the full SHA 2155917View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30cb675 - Browse repository at this point
Copy the full SHA 30cb675View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c1998f - Browse repository at this point
Copy the full SHA 5c1998fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da0d06 - Browse repository at this point
Copy the full SHA 2da0d06View commit details