Partly implemented #647 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
type: feature
status: ready-for-review
This was referenced Jan 7, 2016
Closed
|
I would change the changelog entry to just describe the added functionality without refering to the other issue as it suggest another approach in my opinion. |
| @@ -14,6 +14,7 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by | |||
|
|
|||
| ### Changed | |||
| - All import/open database warnings are now shown in a scrolling text area | |||
| - Implemented #647 (partly): The preview can now be copied | |||
|
LGTM 👍 |
| @@ -422,4 +431,21 @@ public void actionPerformed(ActionEvent e) { | |||
|
|
|||
| } | |||
|
|
|||
| class CopyAction extends AbstractAction { | |||
There was a problem hiding this comment.
Can you name it CopyPreviewAction as we have a lot of other copy actions there as well.
|
Please rebase, then this can be merged in. |
|
Fixed and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to copy the preview panel text. Not exactly what is requested in #647, but probably quite useful.
Note that the key binding is not working (nor is the print preview key working) so I'll open an issue for that.