Add more menu items to library context menu #6551
Conversation
| @@ -1316,6 +1323,31 @@ public void execute() { | |||
| } | |||
| } | |||
|
|
|||
| private class CloseOthersDatabaseAction extends SimpleCommand { | |||
There was a problem hiding this comment.
Maybe you can add a utility method in ActionHelper to check if there are multiple databases present? In that case the entry for this could be disabled if not.
There was a problem hiding this comment.
Do you mean that I only need to disable the menu items when there is only one databese opened but no need to hide these items?
Just like the following is OK?
There was a problem hiding this comment.
Nice!
Tests are nice, but for changes that only concern the UI they are not necessary.
One suggestion: Add also the "Open terminal here" (from View) and a new "Reveal in file explorer" option (that opens the file explorer with the library marked - we should already have the necessary code in place in the JabRefDesktop class if I'm not mistaken).
| factory.createMenuItem(StandardActions.CLOSE_ALL_LIBRARIES, new CloseAllDatabaseAction()), | ||
| new SeparatorMenuItem(), | ||
| factory.createMenuItem(StandardActions.LIBRARY_PROPERTIES, new LibraryPropertiesAction(this, stateManager)), | ||
| factory.createMenuItem(StandardActions.MANAGE_CITE_KEY_PATTERNS, new BibtexKeyPatternAction(this, stateManager)) |
There was a problem hiding this comment.
I wouldn't add the "Manage cite key pattern". It's not that important and also not directly concerned with the library.
There was a problem hiding this comment.
Yeah, I think what you said is very reasonable. I will try to do it.
Siedlerchr
changed the title
|
@tobiasdiez @calixtus I've changed context menu contents as you asked. Waiting for your reply^_^ |
tobiasdiez
added
the
status: ready-for-review
|
@Hollyqqqqq Please fix the checkstyle issues. You can impor the style for intellij and then hit a key to format the code |
|
Sorry for didn't check the checkstyle issues. I'm done now. |
|
I've quickly added the localization information that were still missing (see https://devdocs.jabref.org/getting-into-the-code/code-howtos#using-localization-correctly for the next time) and will merge now. Thanks again for your contribution! Keep them coming 🏎️ |
* upstream/master: (110 commits) Fix DOI import in RIS Importer Rename bibtexkey (#6545) check if fields are empty fix comment checkstyle arght Fix XMP Exctrator not returning empty optional Fix Group hit counter calculation preferences (#6554) add changelog entry Make test concise Add test for getXmpMetadata with no description guidelines updated lint and hint for JEE Update eclipse setting Bump checkstyle from 8.32 to 8.33 Bump classgraph from 4.8.78 to 4.8.80 Add more menu items to library context menu (#6551) Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2 Correct return description in javadoc iterate to get all selected leaf nodes check if metadata has start and end tag Update RisImporterTest.java ...
Fixes #6527
Before fixed:
After fixed:
The following are relative codes. I just add some menu items and some relative action classes to perform actions.
https://github.com/Hollyqqqqq/jabref/blob/cd2fc42237242773685a3b38c2021e07cdbade39/src/main/java/org/jabref/gui/JabRefFrame.java#L1085-L1099