Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix author formatter for unchanged names #6552

Merged
merged 117 commits into from
Jun 16, 2020

Commits on May 13, 2020

  1. Configuration menu
    Copy the full SHA
    fd405cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6354e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    149ed4f View commit details
    Browse the repository at this point in the history
  4. Fix invalid index in call to substring

    The original condition is evaluated to false.
    The substring is shorter than "uni".
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b57f1b2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fae093b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a23a9a View commit details
    Browse the repository at this point in the history
  7. Fix check for uppercase letter

    Perhaps the assumption should be that the letters are ASCII.
    If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z'
    might make more sense.
    I am not convinced about doing this with a regex.
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6af8c7e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    716f885 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cdfd56a View commit details
    Browse the repository at this point in the history
  10. Add test cases

    Both test cases involves an author name containing department or school
     without university or institute of technology.
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b227edb View commit details
    Browse the repository at this point in the history
  11. Fix null appearing as part of author name

    Corporate authors without university/institute of technology
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ef7f979 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Configuration menu
    Copy the full SHA
    9ac3993 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Merge branch 'master' into fix-for-issue-6459

    # Conflicts:
    #	src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java
    k3KAW8Pnf7mkmdSMPHz27 committed May 15, 2020
    Configuration menu
    Copy the full SHA
    85c96ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ded410 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Configuration menu
    Copy the full SHA
    e8c3007 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72eb1fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2eee8dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc54029 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Configuration menu
    Copy the full SHA
    1063ae1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef94758 View commit details
    Browse the repository at this point in the history
  3. Fix key for institution's name containing keyword

    If the name of an institution can't be split, assume that
    "School"/"Department" is part of the name.
    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e80bd8b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a0ed455 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4db0824 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    383fc14 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c3e5f09 View commit details
    Browse the repository at this point in the history
  8. Fix JavaDoc

    Minor typos and the "rest" part is now created differently.
    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5990c2a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0df3cdb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f0d9601 View commit details
    Browse the repository at this point in the history
  11. Drop logger

    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    6f26a73 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Configuration menu
    Copy the full SHA
    9b717c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ed9c54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6e9e70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2dc664d View commit details
    Browse the repository at this point in the history
  5. Fix to only keep the first character of each word

    There are some examples that will turn out wrong if only capital letters
     are kept, e.g., "iOS Developer University Program".
     The original problem with "The School of Life" becoming too short is
     avoided by only removing school/department for names containing two or
      more ',' separated strings. This will still produce an unexpected
       result if the address of the institution is part of the authors field
    k3KAW8Pnf7mkmdSMPHz27 committed May 20, 2020
    Configuration menu
    Copy the full SHA
    f0fd4f1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Configuration menu
    Copy the full SHA
    feebf81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4c2ce3 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Configuration menu
    Copy the full SHA
    04abe5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f3ef62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4fbec1 View commit details
    Browse the repository at this point in the history
  4. Add test for latex-free comma separated first name

    First name first and abbreviated first name first
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    a256fa8 View commit details
    Browse the repository at this point in the history
  5. Add test for latex-free comma separated last name

    Last name first and abbreviated first names
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4961c53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a443db0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dd492e6 View commit details
    Browse the repository at this point in the history
  8. Fix CheckStyle issues

    The deprecated static methods BibtexKeyGenerator.generateKey are moved
    to the test file as a similar convenience method is required for
    the test cases. Suppress warning has been added for some methods.
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    71e45d4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2748dcd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3b0dda3 View commit details
    Browse the repository at this point in the history
  11. Fix mistake in BibtexKeyGeneratorTest

    generateKey was not copy-pasted properly.
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    78b66f7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Configuration menu
    Copy the full SHA
    55ef8e7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Configuration menu
    Copy the full SHA
    237dc35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78fade6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3de984d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecac673 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1c4928b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    55f3f18 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e6cda69 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e120fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8cc947c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Configuration menu
    Copy the full SHA
    2fc9e16 View commit details
    Browse the repository at this point in the history
  2. Refactor formatNameLatexFree

    The author list parsing is moved outside of the if/else statements
    k3KAW8Pnf7mkmdSMPHz27 committed May 27, 2020
    Configuration menu
    Copy the full SHA
    b4b3993 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cb6232 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b3f0d1b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a27bbc View commit details
    Browse the repository at this point in the history
  6. Refactor parse with latex tests

    Move them close to other parse tests
    k3KAW8Pnf7mkmdSMPHz27 committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c7578b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b8bf4f3 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Configuration menu
    Copy the full SHA
    cc23e29 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Configuration menu
    Copy the full SHA
    24398b4 View commit details
    Browse the repository at this point in the history
  2. Add test for latex-free unformatted authors

    Same as for all others
    k3KAW8Pnf7mkmdSMPHz27 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    5308717 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into fix-for-issue-6459

    # Conflicts:
    #	src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java
    #	src/main/java/org/jabref/gui/maintable/MainTableNameFormatter.java
    #	src/main/java/org/jabref/model/entry/AuthorList.java
    #	src/test/java/org/jabref/model/entry/AuthorListTest.java
    k3KAW8Pnf7mkmdSMPHz27 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    b2b523c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94a46e2 View commit details
    Browse the repository at this point in the history
  5. Revert "Add change to CHANGELOG.md"

    This reverts commit 94a46e2
    k3KAW8Pnf7mkmdSMPHz27 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    539c616 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Configuration menu
    Copy the full SHA
    476b5b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2642cb9 View commit details
    Browse the repository at this point in the history
  3. Add AuthorList institution cache test

    Since the name of an institution can be used to create an `Author`
    directly it is the most likely `Author` to contain a reference to the
    original String object and create a memory leak.
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4ecdbf8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b18e60d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e840bc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2bfbd71 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Configuration menu
    Copy the full SHA
    a4cb1ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac8759b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cea4c5e View commit details
    Browse the repository at this point in the history
  4. Fix AuthorList.equals

    Updated JavaDoc and now checks if the other object is itself
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    03a632c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e22a098 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0fd46d7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d50c7cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4b389a6 View commit details
    Browse the repository at this point in the history
  9. Fix update JavaDoc

    The parser is intended to deal with a format that is not BibTeX but
    appears to be used in practice
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    cd68f6c View commit details
    Browse the repository at this point in the history
  10. Fix unique names in test cases

    Make the unique names more realistic
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    f3340b2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    10fff4c View commit details
    Browse the repository at this point in the history
  12. Fix typos

    k3KAW8Pnf7mkmdSMPHz27 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    b5caec8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fbe6501 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7c4faa3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e028993 View commit details
    Browse the repository at this point in the history
  16. Fix typo

    k3KAW8Pnf7mkmdSMPHz27 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    a78460f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4abe855 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    551c6e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    557ffc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    581446b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Configuration menu
    Copy the full SHA
    0020c21 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81c0018 View commit details
    Browse the repository at this point in the history
  3. Fix for getting unformatted latex-free names

    Moving the responsibility of getting the unformatted latex-free name to
    aid in caching and keeping it consistent with other getter functions.
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    26cf448 View commit details
    Browse the repository at this point in the history
  4. Refactor the fields loop

    Move the fields loop from BibEntryTableViewModel to
    MainTableFieldValueFormatter.
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    0942e2c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e562d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Fix reference of bibDatabaseContext in Formatter

    Store a reference to the used BibDatabase in
    MainTableFieldValueFormatter with the constructor.
    k3KAW8Pnf7mkmdSMPHz27 committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    7616fbe View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    4c457f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    d183705 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    431811a View commit details
    Browse the repository at this point in the history
  3. Fix handling of DisplayStyle.AS_IS

    Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>
    k3KAW8Pnf7mkmdSMPHz27 and tobiasdiez authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    8ad3aaf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a81f1e9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c55b1b6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c8380a8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6155e14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1eeddab View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ff9553 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2396fb2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b16d457 View commit details
    Browse the repository at this point in the history
  12. Fix JavaDoc description of AuthorList.equals

    Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
    k3KAW8Pnf7mkmdSMPHz27 and koppor authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    a9e4f72 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d7d692e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0c0e777 View commit details
    Browse the repository at this point in the history