Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restart warning for autocompletion in preferences #6769

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Add restart warning for autocompletion in preferences #6769

merged 8 commits into from
Aug 19, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Aug 18, 2020 •
edited
Loading

Fixes #6351

Finishes the work of @ShiquingLiu in #6564, only some typos and the strings had to be put in the l10n resource.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

newtypes9 and others added 7 commits May 31, 2020 11:22
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 18, 2020
@calixtus calixtus changed the title Shiqing liu fix 6351 Add restart warning for autocompletion in preferences Aug 18, 2020
@github-actions
Copy link
Contributor

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

Qing
ShiqingLiu

tobiasdiez
tobiasdiez approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, not sure about the author strings (Qing looks wrong) @koppor @shiqingliu

@koppor
Copy link
Member

koppor commented Aug 19, 2020

We can merge and I can adjust .mailmap to contain the second one only.

@calixtus calixtus merged commit 04a3b58 into master Aug 19, 2020
@calixtus calixtus deleted the ShiqingLiu-fix-6351 branch August 19, 2020 14:37
Siedlerchr added a commit that referenced this pull request Aug 19, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into macsign
685a56c 
* upstream/master:
  Merge identical group color indicators (#6768)
  Squashed 'src/main/resources/csl-styles/' changes from c8c6c6d..0895562
  Add restart warning for autocompletion in preferences (#6769)
  Fix markdown
  Update description of intelliJ checkstyle configuration (#6766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autocompletion always turned on; cannot be disabled
5 participants
@calixtus @koppor @Siedlerchr @tobiasdiez @newtypes9