Make BibTex parser more robust against missing newlines #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix bug that prevented the import of BibTex entries having only a key as content
tobiasdiez
added
the
status: ready-for-review
| if(atSymbolIndex > 0) | ||
| encoding = line.substring(Globals.encPrefix.length(), atSymbolIndex); | ||
| else | ||
| encoding = line.substring(Globals.encPrefix.length()); |
There was a problem hiding this comment.
Please always use curly braces as this makes the semantics explicit.
|
👍 (except my minor comment) |
|
Corrected... for some reason the code style was not imported correctly in Intellij. |
|
Hm, I just use the default Intellij code style. :) |
simonharrer
added a commit
that referenced
this pull request
Jan 18, 2016
Make BibTex parser more robust against missing newlines
|
@tobiasdiez: what do you think should be done to fix the above issues completely? |
|
@lenhard In my opinion JabRef should add new lines after the encoding and preamble. I'm working on a solution right now (including a 'bit' of refactoring to make testing easier). |
|
@tobiasdiez Ok, good to hear! I'll concentrate on other issues then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #669 and #621 the parser has some problems when an entry (or preamble) follows directly the file encoding header (on the same line), i.e.
% Encoding: myEncoding @article{...}.Actually, as the tests reveal it was not a problem with the actual parser but within the file opening logic.
I don't view this PR as a complete fix for #669 and #621 since not just the parser but also the serialization should be improved.
Also fix a bug that prevented the import of BibTex entries having only a key as its content.