Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that current database is "shared" #7033

Closed
wants to merge 1 commit into from

Conversation

Gena928
Copy link
Contributor

@Gena928 Gena928 commented Oct 20, 2020

Fixes #6959
JabRef always tries to pull changes from shared database, even if current database is not shared.
Added filter to ensure that current db is shared.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Gena928 Gena928 changed the title Additiona filter on execute() method, to ensure we are connected to s… Make sure that current database is "shared" Oct 20, 2020
@koppor
Copy link
Member

koppor commented Oct 20, 2020

The original issue did not provide a screenshot. I guess that "Pull changes from database" is enabled even if there isn't a shared database. Thus, the solution is NOT to fix the action pulling the changes, but to fix the menu entry being enabled only for shared datbases.

Related: koppor#419

@Gena928
Copy link
Contributor Author

Gena928 commented Oct 21, 2020

@koppor ,
thanks for a comment. Indeed, now I see that filtering DB type is ugly solution. I'll try to make a new one.

@Gena928 Gena928 closed this Oct 21, 2020
@Siedlerchr
Copy link
Member

The idea is not bad, just at the wrong position.
The solution would be to create another BooleanExpression in the ActionHelper class, e..g needsSharedDatabase
filter there
And in the action you can then bind it, e..g:
this.executable.bind(ActionHelper.needsEntriesSelected(stateManager));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when "pulling changes" from local database
3 participants