Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Try with jaxb 3.0 and xjc #7161

Closed
wants to merge 7 commits into from
Closed

[WIP] Try with jaxb 3.0 and xjc #7161

wants to merge 7 commits into from

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 4, 2020

Fixes #7137

Finally I was able to fix this jaxb jakarta dependeny update. Hellish complicated with all those implementaitons and version numbers and different namespaces ☺️

TODO:

  • Depends on xmpbox/pdfbox
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 4, 2020
@Siedlerchr
Copy link
Member Author

Hm:

Error: Two versions of module jakarta.activation found in /Users/runner/work///build/jlinkbase/jlinkjars (jakarta.activation-api-2.0.0.jar and jakarta.activation-2.0.0.jar)

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Dec 4, 2020

The failing xmp test seems to come from:

java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter
Seems to be a problem with pdfbox not yet beeing jakarta compatible argh!

@Siedlerchr
Copy link
Member Author

The problem is https://github.com/apache/pdfbox/blob/5f6c8b4e1fd32396889206f2222dce26480d2a95/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java

xmpbox/pdfbox still depends on javax.xml.bind that is obviously no longer present.

@Siedlerchr Siedlerchr added the status: freeze Issues posponed to a (much) later future label Dec 6, 2020
@tobiasdiez
Copy link
Member

@Siedlerchr have you reported the issues upstream with xmpbox?

@Siedlerchr
Copy link
Member Author

@koppor wanted to do this because he already has an account at the apache

@koppor
Copy link
Member

koppor commented Dec 28, 2020

Issue submitted: https://issues.apache.org/jira/browse/PDFBOX-5061

Pull request fixing the issue submitted: apache/pdfbox#101

@Siedlerchr
Copy link
Member Author

Siedlerchr commented May 4, 2021

XMP is now working with pdfbox 3.0.0.
Current problem: application insights 2.x contain dependency to xml.bind. Seems to be removed in newer version but that is not yet? No idea

@tobiasdiez
Copy link
Member

Application insights uses a fat jar that contains all dependencies microsoft/ApplicationInsights-Java#1060, so this shouldn't actually be a problem.

@Siedlerchr
Copy link
Member Author

Well, the original error was.

aused by: java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
        at com.microsoft.applicationinsights.internal.config.TelemetryConfigurationFactory.<init>(TelemetryConfigurationFactory.java:90) ~[applicationinsights-core-2.4.1.jar:?]
        at com.microsoft.applicationinsights.internal.config.TelemetryConfigurationFactory.<clinit>(TelemetryConfigurationFactory.java:66) ~[applicationinsights-core-2.4.1.jar:?]
        at com.microsoft.applicationinsights.TelemetryConfiguration.getActive(TelemetryConfiguration.java:70) ~[applicationinsights-core-2.4.1.jar:?]
    at org.jabref.gui.Globals.startTelemetryClient(Globals.java:122) ~[JabRef-100.0.0.jar:?]

With version 3.x they also changed the approach. Apparently they now use an java agent. Not exactly sure.
https://docs.microsoft.com/de-de/azure/azure-monitor/app/java-get-started?tabs=maven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: freeze Issues posponed to a (much) later future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants